making sure that the hostname is in lowercase otherwise mariadb breaks #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you provide more info about why it breaks? |
Contributor
Author
|
The ansible output TASK: [mariadb | mariadb | Update root password for all root accounts] ********
failed: [192.168.33.99] => (item=Default) => {"failed": true, "item": "Default", "parsed": false}
invalid output was: SUDO-SUCCESS-lscrmpovsmrjuppikcfropqdxbbtbmhs
Traceback (most recent call last):
File "/home/vagrant/.ansible/tmp/ansible-tmp-1417685988.27-271678323726266/mysql_user", line 1822, in <module>
main()
File "/home/vagrant/.ansible/tmp/ansible-tmp-1417685988.27-271678323726266/mysql_user", line 466, in main
changed = user_add(cursor, user, host, password, priv)
File "/home/vagrant/.ansible/tmp/ansible-tmp-1417685988.27-271678323726266/mysql_user", line 164, in user_add
cursor.execute("CREATE USER %s@%s IDENTIFIED BY %s", (user,host,password))
File "/usr/lib/python2.7/dist-packages/MySQLdb/cursors.py", line 174, in execute
self.errorhandler(self, exc, value)
File "/usr/lib/python2.7/dist-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
raise errorclass, errorvalue
_mysql_exceptions.OperationalError: (1396, "Operation CREATE USER failed for 'root'@'default'")
changed: [192.168.33.99] => (item=127.0.0.1)
changed: [192.168.33.99] => (item=::1)
changed: [192.168.33.99] => (item=localhost)
FATAL: all hosts have already failed -- aborting
PLAY RECAP ********************************************************************
to retry, use: --limit @/home/mike/playbook.retry
192.168.33.99 : ok=22 changed=18 unreachable=0 failed=1
Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.As you can see mysql/mariadb is creating a user with "Default" in lowercase and then try to change the passowrd with the uppercase version and that's why it breaks. |
Contributor
|
This is a simple PR and makes a lot of sense. I mean, why should we allow uppercase letters for hostname if no one should use it? It's ok to merge, IMO. |
Contributor
|
yes. for me is a merge. |
naxhh
added a commit
that referenced
this pull request
Dec 4, 2014
making sure that the hostname is in lowercase otherwise mariadb breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently there is no reason to have upper-case in the first place as the dns records are case insensitive