Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug]: Asset::updateChildPaths() can delete S3 source directory even when no files were moved (data loss risk on cloud storage) #18797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2025
Merged

[Bug]: Asset::updateChildPaths() can delete S3 source directory even when no files were moved (data loss risk on cloud storage) #18797

merged 5 commits into from
Nov 3, 2025
+29 −8

Conversation

@kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Oct 31, 2025

Changes in this pull request

Resolves #18794

Additional info

Applying suggsted change in a draft

@kingjia90 kingjia90 added this to the 11.5.12 milestone Oct 31, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 force-pushed the fix-delete-assets-updatechild branch from 1789353 to 6aec310 Compare October 31, 2025 11:54
@kingjia90 kingjia90 linked an issue Oct 31, 2025 that may be closed by this pull request
[Bug]: Asset::updateChildPaths() can delete S3 source directory even when no files were moved (data loss risk on cloud storage) #18794
Closed
@kingjia90 kingjia90 marked this pull request as ready for review October 31, 2025 13:04
kingjia90
kingjia90 commented Nov 3, 2025
View reviewed changes
@kingjia90 kingjia90 self-assigned this Nov 3, 2025
@kingjia90 kingjia90 force-pushed the fix-delete-assets-updatechild branch from 683f842 to 4aa912d Compare November 3, 2025 10:05
@kingjia90 kingjia90 force-pushed the fix-delete-assets-updatechild branch from e044af5 to cd71784 Compare November 3, 2025 10:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 merged commit 4748c2b into 11.5 Nov 3, 2025
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
@kingjia90 kingjia90 deleted the fix-delete-assets-updatechild branch November 3, 2025 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kingjia90 kingjia90

Labels

Bug Pimcore:Priority

Projects

None yet

Milestone

11.5.12

Development

Successfully merging this pull request may close these issues.

[Bug]: Asset::updateChildPaths() can delete S3 source directory even when no files were moved (data loss risk on cloud storage)

2 participants

@kingjia90