Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: add new ci collation without old value test #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 21, 2021
Merged

test: add new ci collation without old value test #3114

merged 10 commits into from
Oct 21, 2021

Conversation

@0xPoe
Copy link
Member

@0xPoe 0xPoe commented Oct 21, 2021 •
edited
Loading

What problem does this PR solve?

Prepare for more old value tests.

What is changed and how it works?

rename new ci collation test to new ci collation with old value test.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 21, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2021
@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-all-tests

@0xPoe 0xPoe requested review from ben1009 and overvenus October 21, 2021 08:11
@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-unit-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2021
@0xPoe 0xPoe changed the title test: rename new ci collation test test: add new ci collation without old value test Oct 21, 2021
@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2021
@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-all-tests

@0xPoe 0xPoe changed the title test: add new ci collation without old value test WIP: test: add new ci collation without old value test Oct 21, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2021
@amyangfei amyangfei added this to the v5.3.0 milestone Oct 21, 2021
@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-all-tests

@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-kafka-tests

@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-all-tests

@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-all-tests

@overvenus
Copy link
Member

overvenus commented Oct 21, 2021

/run-kafka-tests
/run-integration-tests

1 similar comment
@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-kafka-tests
/run-integration-tests

@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-kafka-tests

4 similar comments
@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-kafka-tests

@amyangfei
Copy link
Contributor

amyangfei commented Oct 21, 2021

/run-kafka-tests

@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-kafka-tests

@0xPoe
Copy link
Member Author

0xPoe commented Oct 21, 2021

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 7bba941 into pingcap:master Oct 21, 2021
@0xPoe 0xPoe deleted the rustin-patch-test-new-collation branch October 21, 2021 15:06
liuzix pushed a commit that referenced this pull request Oct 25, 2021
@0xPoe @liuzix
test: add new ci collation without old value test (#3114)
331aecc
liuzix pushed a commit that referenced this pull request Oct 25, 2021
@0xPoe @liuzix
test: add new ci collation without old value test (#3114)
7035380
@0xPoe 0xPoe added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Nov 10, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 10, 2021
@0xPoe @ti-chi-bot
test: add new ci collation without old value test (pingcap#3114)
61e5b3c
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2021

In response to a cherrypick label: new pull request created: #3368.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2021

In response to a cherrypick label: new pull request created: #3367.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2021

In response to a cherrypick label: new pull request created: #3369.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2021

In response to a cherrypick label: new pull request created: #3370.

0xPoe added a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2021
@0xPoe
test: add new ci collation without old value test (pingcap#3114)
ee258a1
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot
test: add new ci collation without old value test (#3114) (#3370)
46d2487
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot
test: add new ci collation without old value test (#3114) (#3367)
2f5ccfd
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot
test: add new ci collation without old value test (#3114) (#3369)
8aa2102
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
@ti-chi-bot
test: add new ci collation without old value test (#3114) (#3368)
652a6f2
3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 25, 2021
@ti-chi-bot @3AceShowHand
test: add new ci collation without old value test (pingcap#3114) (pin…
6fad381 
…gcap#3368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

+1 more reviewer

@ben1009 ben1009 ben1009 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

v5.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@0xPoe @ti-chi-bot @amyangfei @overvenus @ben1009