mysql sink: add a batch size limiter #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
added 2 commits
March 12, 2020 17:04
amyangfei
reviewed
Mar 12, 2020
added 2 commits
March 12, 2020 21:40
# Conflicts: # cdc/sink/mysql.go
|
/run-all-tests |
|
/run-integration-test |
|
/run-integration-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 28.72% 28.72%
=======================================
Files 59 59
Lines 5559 5559
=======================================
Hits 1597 1597
Misses 3817 3817
Partials 145 145Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add a batch size limiter for mysql.
What is changed and how it works?
Check List
Tests