codec(cdc): fix encoder max-message-bytes (#4074)
#4077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
Co-authored-by: amyangfei <[email protected]>
amyangfei
approved these changes
Dec 27, 2021
9c505b1 to
4bf83dc
Compare
Codecov Report
@@ Coverage Diff @@
## release-5.1 #4077 +/- ##
================================================
Coverage ? 64.1878%
================================================
Files ? 160
Lines ? 16782
Branches ? 0
================================================
Hits ? 10772
Misses ? 5071
Partials ? 939 |
Contributor
|
/run-integration-test |
overvenus
approved these changes
Dec 27, 2021
0xPoe
approved these changes
Dec 27, 2021
Member
|
/merge |
Member
Author
|
This pull request has been accepted and is ready to merge. Commit hash: bd8a6e1
|
Member
|
/hold Waiting for manual testing |
Contributor
|
/run-all-tests |
Contributor
|
/run-kafka-integration-test |
Member
|
/unhold |
Member
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4074
What problem does this PR solve?
when initializing the encoder, make sure
max-message-bytesin theopts, and set identical to producer's configuration.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note