Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mfikes
Copy link
Member

@mfikes mfikes commented Jun 18, 2019

For #651

@mfikes
Copy link
Member Author

mfikes commented Jun 18, 2019

See associated ticket for details on how this patch is meant to be used.

@mfikes
Copy link
Member Author

mfikes commented Jun 18, 2019

FWIW, @manutter51 independently confirmed that this patch worked

@mfikes mfikes marked this pull request as ready for review July 6, 2019 12:40
@mfikes mfikes requested a review from pyrmont July 6, 2019 12:41
@mfikes
Copy link
Member Author

mfikes commented Jul 6, 2019

@pyrmont The inelegant use of str->bytes and vector construction in this PR has bothered me, but I haven't thought of a cleaner way to write this, so putting it in for review.

@mfikes
Copy link
Member Author

mfikes commented Jul 6, 2019

Oh, I see that I haven't added any associated documentation for this change. Let me do that.

@mfikes mfikes force-pushed the http-upload-binary branch from 707d591 to b7abecc Compare July 6, 2019 12:45
@mfikes
Copy link
Member Author

mfikes commented Jul 6, 2019

Rebaselined via force-push.

@mfikes
Copy link
Member Author

mfikes commented Jul 6, 2019

OK, even though the documentation is thin, we may be OK. We have the fact that :body can be binary:

(s/def ::body (s/or :string string? :binary vector?))

and in the :multipart-params portion of the docstring it has:

can be a string or a vector of unsigned bytes (binary)

Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some questions:

@mfikes mfikes merged commit 31c2127 into master Jul 8, 2019
@mfikes mfikes deleted the http-upload-binary branch July 8, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants