GCL lib analysis issue with ClojureScript master #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1011
This fixes the issue by simply causing the JVM compiler to have a version of GCL on the classpath which is closer to the one Planck ships with.
Ideally, in the future, Planck should ship with a version that is identical to the one that it puts on the JVM classpath. This would be good for the next ClojureScript compiler release because that release does type analysis of Closure libraries, which leads to additional type inference, and thus potentially different code gen.
To pull that off, we’d probably need to stop fetching the GCL ZIP from GitHub but instead only make use of the Clojure-built google-closure-library JAR for everything.