Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use connectors instead of jit req inspector #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 7, 2025
Merged

Use connectors instead of jit req inspector #730

merged 10 commits into from
Nov 7, 2025

Conversation

@soundofspace
Copy link
Collaborator

@soundofspace soundofspace commented Nov 5, 2025 •
edited
Loading

  • Jit request inspectors also need access to connection to access extensions, and at this point, it's just a connector. So remove JIT logic and just use normal connectors instead
  • Layers to adapt Request and Response version
  • Modify easy web client to use this new logic

part of #462

@soundofspace soundofspace marked this pull request as ready for review November 7, 2025 09:51
@soundofspace soundofspace requested a review from GlenDC November 7, 2025 09:51
GlenDC
GlenDC approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Couple of remarks, but we can probably ship this still today if you are quick enough :) So exciting, looks good. A lot cleaner.

Any concerns that aren't immediately clear from the PR? E.g. things that you have in your mind after having gone through all this code?

rama-tls-rustls/Cargo.toml Outdated
[dependencies]
pin-project-lite = { workspace = true }
rama-core = { workspace = true }
rama-http-types = { workspace = true }
Copy link
Member

@GlenDC GlenDC Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we already were enabling rama-http-types via rama-net/http before, but ... why is this required?

rama-tls* crates should probably also be able to work without http as there is plenty of use case of tls without http. Can we put a feature flag (http) here to enable this optionally? What stops us?

@soundofspace
Copy link
Collaborator Author

soundofspace commented Nov 7, 2025 •
edited
Loading

Any concerns that aren't immediately clear from the PR? E.g. things that you have in your mind after having gone through all this code?

Something I'm still thinking about but I'm not entirely sure about http_req_inspector_svc I wonder if these should also just be normal services/layers. It feels like http-backend service is doing way too much. Removing JIT was actually a huge pleasure and in my opinion made everything easier

@GlenDC
Copy link
Member

GlenDC commented Nov 7, 2025

Any concerns that aren't immediately clear from the PR? E.g. things that you have in your mind after having gone through all this code?

Something I'm still thinking about but I'm not entirely sure about http_req_inspector_svc I wonder if these should also just be normal services/layers. It feels like http-backend service is doing way too much. Removing JIT was actually a huge pleasure and in my opinion made everything easier

I am not against simpler. Feel free to make a more in depth proposal offline, discord or github.

@soundofspace soundofspace self-assigned this Nov 7, 2025
@soundofspace soundofspace requested a review from GlenDC November 7, 2025 17:58
@GlenDC GlenDC merged commit 9162627 into main Nov 7, 2025
31 of 32 checks passed
@GlenDC GlenDC deleted the use-connectors-instead-of-jit-req-inspector branch November 7, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GlenDC GlenDC GlenDC approved these changes

Assignees

@soundofspace soundofspace

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soundofspace @GlenDC