Fix warnings in port to Gnome 44 #6
Conversation
|
I just realized that this would break gnome 43 and lower support. What is your policy for that? Support the latest version only? Fork for gnome 44 support? Or is there a smart way to check the gnome version at runtime and support them both? :) |
|
Regression is not acceptable as this may cause problems for existing users, and mainstream version of I personally prefer checking GNOME version, if eliminating warning is important. But GNOME extension interface is well known for its unstablity, and even break existing extensions from time to time. Will this warning become error or make no effect in future? |
|
Heya, the field is deprecated, so it will likely be removed in the future, I guess with gnome 45(?) resulting in an error. I'm happy to add a shell version check around it :) |
Heya, running fedora silverblue 38 with Gnome 44 and noticed that the extension causes the following warnings from gnome-shell when activating it and when it updates the remaining time:
$ journalctl -f /usr/bin/gnome-shell Mar 12 16:16:07 fedora gnome-shell[1332]: Trying to set label on QuickToggle. Use title instead.This patch fixes that.