add discharge rate #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for you PR! However, adding discharge rate takes more space, and I prefer this as an option. And on devices with charge threshold, like ThinkPad with TLP configured, when the battery is neither charging nor discharging, and the computer is on AC power, UPower may still report a stale value of energy consumption. |
Author
|
I have a ThinkPad and access to another one and I use thresholds, so I will
test that. Don't think I've noticed the problem on mine. I guess making it
an option is the solution.
I also will add an indicator "L" when it is in laptop mode (throttled due
to motion detection), I'll put that behind an option too. This is not a
upower stat, it requires reading a file. It stays in throttled mode for
about three minutes and entering this mode can be triggered quite easily, I
find it very useful to know when it's throttled due to this.
…On Sun, 27 Nov 2022 at 22:30, pomoke ***@***.***> wrote:
Thanks for you PR!
However, adding discharge rate takes more space, and I prefer this as an
option.
And on devices with charge threshold, like ThinkPad with TLP configured,
when the battery is neither charging nor discharging, and the computer is
on AC power, UPower may still report a stale value of energy consumption.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHCNYSOE5TCQRLZPTC6LFDWKNA6HANCNFSM6AAAAAASK7SAP4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Tim Richardson CPA, Director, BA, BSc, MAcc*
GrowthPath. Finance transformation for SMEs via Cloud ERP, advanced
reporting, CRM
Mobile: +61 423 091 732 Office/Reception: +61 3 8678 1850.
Book call: https://vyte.in/growthpath/15
Timezone is Melbourne AU.
See this link for international time planning:
https://www.timeanddate.com/worldclock/meeting.html?year=2020&month=5&day=16&p1=152
GrowthPath Pty Ltd ABN 18100392326
<http://www.growthpath.com.au/>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1 Adds discharge rate (or charge rate)