forked from bowbahdoe/boba
-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
bugSomething isn't workingSomething isn't working
Milestone
Description
We need to make sure that when the program closes we re-cook the terminal (take it out of raw mode or revert to whatever it was previously). I have attempted to do this in the MacTerminal_intel and MacTerminal_arm64 implementations by storing a cloned MemorySegment of the settings before we make them "raw" and then simply restoring this on shutdown. From my testing it doesn't work and I haven't given it a deeper look. I think more than just a shutdown hook we need a proper api to call this since we cannot assume that the program finishing is the only indicator that they are done using our library. (Generally we should avoid shutdown hooks unless we can clean them up at runtime)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working