Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix colour penalties being bypassed via repeated ratio variance #33641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2025
Merged

Fix colour penalties being bypassed via repeated ratio variance #33641

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58ae5f8
fix a lil bit of colour
Lawtrohux Jun 11, 2025
0c955be
review comments
Lawtrohux Jun 17, 2025
53fb2f7
fix empty initialiser
Lawtrohux Jul 26, 2025
10dd589
Merge branch 'pp-dev' into ratio-fallback
stanriders Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions osu.Game.Rulesets.Taiko/Difficulty/Evaluators/ColourEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// See the LICENCE file in the repository root for full licence text.

using System;
using System.Collections.Generic;
using System.Linq;
using osu.Game.Rulesets.Difficulty.Preprocessing;
using osu.Game.Rulesets.Difficulty.Utils;
using osu.Game.Rulesets.Taiko.Difficulty.Preprocessing;
Expand All @@ -24,19 +26,21 @@ private static double consistentRatioPenalty(TaikoDifficultyHitObject hitObject,
int consistentRatioCount = 0;
double totalRatioCount = 0.0;

List<double> recentRatios = new List<double>();
TaikoDifficultyHitObject current = hitObject;
var previousHitObject = (TaikoDifficultyHitObject)current.Previous(1);

for (int i = 0; i < maxObjectsToCheck; i++)
{
// Break if there is no valid previous object
if (current.Index <= 1)
break;

var previousHitObject = (TaikoDifficultyHitObject)current.Previous(1);

double currentRatio = current.RhythmData.Ratio;
double previousRatio = previousHitObject.RhythmData.Ratio;

recentRatios.Add(currentRatio);

// A consistent interval is defined as the percentage difference between the two rhythmic ratios with the margin of error.
if (Math.Abs(1 - currentRatio / previousRatio) <= threshold)
{
Expand All @@ -45,14 +49,21 @@ private static double consistentRatioPenalty(TaikoDifficultyHitObject hitObject,
break;
}

// Move to the previous object
current = previousHitObject;
}

// Ensure no division by zero
double ratioPenalty = 1 - totalRatioCount / (consistentRatioCount + 1) * 0.80;
if (consistentRatioCount > 0)
return 1 - totalRatioCount / (consistentRatioCount + 1) * 0.80;

if (recentRatios.Count <= 1) return 1.0;

// As a fallback, calculate the maximum deviation from the average of the recent ratios to ensure slightly off-snapped objects don't bypass the penalty.
double maxRatioDeviation = recentRatios.Max(r => Math.Abs(r - recentRatios.Average()));

double consistentRatioPenalty = 0.7 + 0.3 * DifficultyCalculationUtils.Smootherstep(maxRatioDeviation, 0.0, 1.0);

return ratioPenalty;
return consistentRatioPenalty;
}

/// <summary>
Expand Down
Loading