Added parsing netfilter conntrack statistics from net/stat/nf_conntrack #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgier
reviewed
Jan 23, 2020
net_conntrackstat.go
Outdated
| // A ConntrackStatEntry represents one line from net/stat/nf_conntrack | ||
| // and contains netfilter conntrack statistics at one CPU core | ||
| type ConntrackStatEntry struct { | ||
| CPU int |
There was a problem hiding this comment.
Is CPU necessary here? Seems like this can be determined by the location in the slice.
There was a problem hiding this comment.
Yeah, probably this is excessive, removed it.
net_conntrackstat.go
Outdated
| @@ -0,0 +1,154 @@ | |||
| // Copyright 2019 The Prometheus Authors | |||
net_conntrackstat_test.go
Outdated
| @@ -0,0 +1,89 @@ | |||
| // Copyright 2018 The Prometheus Authors | |||
|
Fixes #217 |
| } | ||
|
|
||
| // Parses a ConntrackStatEntry from given array of fields | ||
| func parseConntrackStatEntry(fields []string) (*ConntrackStatEntry, error) { |
There was a problem hiding this comment.
Check for length of fields to prevent a runtime panic.
|
Thanks for the update, looks like the new commit doesn't have a signoff, you can either squash it into the first commit, or do a |
5089553 to
018e4fe
Compare
Signed-off-by: Aleksandr Kozlov <[email protected]>
018e4fe to
2285920
Compare
👌 |
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
Added parsing netfilter conntrack statistics from net/stat/nf_conntrack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parsing of conntrack statistics from procfs for this PR in node_exporter project: prometheus/node_exporter#1155
@discordianfish please review