-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Prevent unclean dealloc of SystemState #33128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 2 commits into
project-chip:master
from
ksperling-apple:dcf-unclean-shutdown
Apr 25, 2024
Merged
Prevent unclean dealloc of SystemState #33128
mergify
merged 2 commits into
project-chip:master
from
ksperling-apple:dcf-unclean-shutdown
Apr 25, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per current documentation calling Shutdown while any controller is alive is already prohibited. Also rename the recently-introduced isShutdown method to isShutDown.
|
PR #33128: Size comparison from 17c8285 to 6bb4a87 Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Apr 24, 2024
saurabhst
approved these changes
Apr 24, 2024
andy31415
approved these changes
Apr 24, 2024
andy31415
reviewed
Apr 24, 2024
Upon closer reading Shutdown() was already guaranteed to be called and ensures that the reference count is 0 at that time, but the documentation was wrong.
|
PR #33128: Size comparison from 17c8285 to d7173dd Increases (1 build for esp32)
Decreases (3 builds for efr32, esp32)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per current documentation calling Shutdown while any controller is alive is already prohibited. But at the moment, calling
Shutdownwhile there are unbalancedRetainSystemStatecalls outstanding is broken in that we deallocate the SystemState without calling itsShutdownmethod, i.e. various parts of the stack don't get stopped correctly. This change explicitly prohibits this.Also rename the recently-introduced isShutdown method to isShutDown.