Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ICD] Fix comment mistakes from post-merge reviews #33225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2024
Merged

[ICD] Fix comment mistakes from post-merge reviews #33225

merged 3 commits into from
Apr 29, 2024

Conversation

@mkardous-silabs
Copy link
Contributor

@mkardous-silabs mkardous-silabs commented Apr 29, 2024

Description

These two PRs has post-merge reviews. PR fixes the comments from these PRs.
#33081
#33174

Tests

CI since only comment changes and a rename

@github-actions github-actions bot added app icd Intermittently Connected Devices protocols labels Apr 29, 2024
@pullapprove pullapprove bot added review - pending and removed app icd Intermittently Connected Devices protocols labels Apr 29, 2024
@github-actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

PR #33225: Size comparison from ae5d772 to 50ad583

Full report (18 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32)
platform target config section ae5d772 50ad583 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 784164 784164 0 0.0
(read/write) 176660 176660 0 0.0
.bss 98604 98604 0 0.0
.data 3588 3588 0 0.0
.rodata 83092 83092 0 0.0
.text 700804 700804 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 800020 800020 0 0.0
(read/write) 187148 187148 0 0.0
.bss 109092 109092 0 0.0
.data 3588 3588 0 0.0
.rodata 77084 77084 0 0.0
.text 722672 722672 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788884 788884 0 0.0
(read/write) 181268 181268 0 0.0
.bss 103212 103212 0 0.0
.data 3588 3588 0 0.0
.rodata 103996 103996 0 0.0
.text 684620 684620 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 741164 741164 0 0.0
(read/write) 175636 175636 0 0.0
.bss 97344 97344 0 0.0
.data 3580 3580 0 0.0
.rodata 78756 78756 0 0.0
.text 662140 662140 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726804 726804 0 0.0
(read/write) 175844 175844 0 0.0
.bss 97568 97568 0 0.0
.data 3572 3572 0 0.0
.rodata 74540 74540 0 0.0
.text 651996 651996 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 588198 588198 0 0.0
(read/write) 208372 208372 0 0.0
.bss 201596 201596 0 0.0
.data 1652 1652 0 0.0
.rodata 87654 87654 0 0.0
.text 498424 498424 0 0.0
lock CC3235SF_LAUNCHXL (read only) 634382 634382 0 0.0
(read/write) 208636 208636 0 0.0
.bss 202000 202000 0 0.0
.data 1516 1516 0 0.0
.rodata 108342 108342 0 0.0
.text 523916 523916 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536312 2536312 0 0.0
.bss 220808 220808 0 0.0
.data 5216 5216 0 0.0
.text 1498996 1498996 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1059928 1059928 0 0.0
bss 139171 139171 0 0.0
rodata 101560 101560 0 0.0
text 771904 771904 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1237136 1237136 0 0.0
bss 137443 137443 0 0.0
rodata 151392 151392 0 0.0
text 798268 798268 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1007360 1007360 0 0.0
bss 138029 138029 0 0.0
rodata 88824 88824 0 0.0
text 733216 733216 0 0.0
nxp contact k32w0+release (read only) 575916 575916 0 0.0
(read/write) 83140 83140 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575380 575380 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703300 703300 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589856 589856 0 0.0
light k32w0+release (read only) 609944 609944 0 0.0
(read/write) 82600 82600 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609408 609408 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795208 795208 0 0.0
.bss 80736 80736 0 0.0
.data 2064 2064 0 0.0
.text 673040 673040 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133492 1133492 0 0.0
.bss 102620 102620 0 0.0
.data 856 856 0 0.0
.text 645872 645872 0 0.0
lock-app qpg6105+debug (read/write) 1093460 1093460 0 0.0
.bss 97292 97292 0 0.0
.data 860 860 0 0.0
.text 605844 605844 0 0.0
stm32 light STM32WB5MM-DK (read/write) 605121 605121 0 0.0
.bss 128468 128468 0 0.0
.data 688 688 0 0.0
.rodata 80532 80532 0 0.0
.text 385688 385688 0 0.0

tcarmelveilleux
tcarmelveilleux reviewed Apr 29, 2024
View reviewed changes
tcarmelveilleux
tcarmelveilleux reviewed Apr 29, 2024
View reviewed changes
@mkardous-silabs @tcarmelveilleux
Update src/app/icd/server/ICDManager.h
5985a00 
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@github-actions github-actions bot added app icd Intermittently Connected Devices protocols labels Apr 29, 2024
tcarmelveilleux
tcarmelveilleux reviewed Apr 29, 2024
View reviewed changes
@mkardous-silabs @tcarmelveilleux
Update src/app/icd/server/ICDManager.h
9dbacee 
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

PR #33225: Size comparison from ae5d772 to 9dbacee

Decreases (2 builds for efr32)
platform target config section ae5d772 9dbacee change % change
efr32 lighting-app BRD4187C (read/write) 1069888 1069880 -8 -0.0
.text 886460 886452 -8 -0.0
lock-app BRD4338a (read/write) 963708 963700 -8 -0.0
.text 703528 703520 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section ae5d772 9dbacee change % change
bl602 lighting-app bl602 (read/write) 1443554 1443554 0 0.0
.bss 85720 85720 0 0.0
.data 9512 9512 0 0.0
.rodata 159220 159220 0 0.0
.text 1108442 1108442 0 0.0
bl602+mfd (read/write) 1457970 1457970 0 0.0
.bss 85888 85888 0 0.0
.data 9488 9488 0 0.0
.rodata 158180 158180 0 0.0
.text 1123760 1123760 0 0.0
bl602+rpc (read/write) 1491194 1491194 0 0.0
.bss 93760 93760 0 0.0
.data 9888 9888 0 0.0
.rodata 166788 166788 0 0.0
.text 1140088 1140088 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209379 1209379 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108816 108816 0 0.0
.text 978712 978712 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220219 1220219 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107756 107756 0 0.0
.text 990466 990466 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1300867 1300867 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124188 124188 0 0.0
.text 1053420 1053420 0 0.0
bl706-eth (read/write) 1025897 1025897 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101904 101904 0 0.0
.text 768670 768670 0 0.0
bl706-wifi (read/write) 1260758 1260758 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122904 122904 0 0.0
.text 1000762 1000762 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1178720 1178720 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102820 102820 0 0.0
.text 971566 971566 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190116 1190116 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101760 101760 0 0.0
.text 983888 983888 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 784164 784164 0 0.0
(read/write) 176660 176660 0 0.0
.bss 98604 98604 0 0.0
.data 3588 3588 0 0.0
.rodata 83092 83092 0 0.0
.text 700804 700804 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 800020 800020 0 0.0
(read/write) 187148 187148 0 0.0
.bss 109092 109092 0 0.0
.data 3588 3588 0 0.0
.rodata 77084 77084 0 0.0
.text 722672 722672 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788884 788884 0 0.0
(read/write) 181268 181268 0 0.0
.bss 103212 103212 0 0.0
.data 3588 3588 0 0.0
.rodata 103996 103996 0 0.0
.text 684620 684620 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 741164 741164 0 0.0
(read/write) 175636 175636 0 0.0
.bss 97344 97344 0 0.0
.data 3580 3580 0 0.0
.rodata 78756 78756 0 0.0
.text 662140 662140 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726804 726804 0 0.0
(read/write) 175844 175844 0 0.0
.bss 97568 97568 0 0.0
.data 3572 3572 0 0.0
.rodata 74540 74540 0 0.0
.text 651996 651996 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 588198 588198 0 0.0
(read/write) 208372 208372 0 0.0
.bss 201596 201596 0 0.0
.data 1652 1652 0 0.0
.rodata 87654 87654 0 0.0
.text 498424 498424 0 0.0
lock CC3235SF_LAUNCHXL (read only) 634382 634382 0 0.0
(read/write) 208636 208636 0 0.0
.bss 202000 202000 0 0.0
.data 1516 1516 0 0.0
.rodata 108342 108342 0 0.0
.text 523916 523916 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570847 570847 0 0.0
.app_xip_area 460757 460757 0 0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 553031 553031 0 0.0
.app_xip_area 438269 438269 0 0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573607 573607 0 0.0
.app_xip_area 465013 465013 0 0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 566071 566071 0 0.0
.app_xip_area 454293 454293 0 0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069888 1069880 -8 -0.0
.bss 179976 179976 0 0.0
.data 3432 3432 0 0.0
.text 886460 886452 -8 -0.0
lock-app BRD4338a (read/write) 963708 963700 -8 -0.0
.bss 210528 210528 0 0.0
.data 30288 30288 0 0.0
.text 703528 703520 -8 -0.0
window-app BRD4187C (read/write) 1136556 1136556 0 0.0
.bss 164568 164568 0 0.0
.data 3336 3336 0 0.0
.text 968632 968632 0 0.0
esp32 all-clusters-app c3devkit (read only) 1215526 1215526 0 0.0
(read/write) 1751352 1751352 0 0.0
.dram0.bss 74616 74616 0 0.0
.dram0.data 13652 13652 0 0.0
.flash.rodata 253544 253544 0 0.0
.flash.text 1215526 1215526 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256751 1256751 0 0.0
(read/write) 537732 537732 0 0.0
.dram0.bss 81368 81368 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 285248 285248 0 0.0
.flash.text 1250587 1250587 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2654389 2654389 0 0.0
(read/write) 130384 130384 0 0.0
.bss 47016 47016 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 184944 184944 0 0.0
.text 2290165 2290165 0 0.0
all-clusters-app debug (read only) 5969961 5969961 0 0.0
(read/write) 482024 482024 0 0.0
.bss 135328 135328 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334712 334712 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 351920 351920 0 0.0
.text 5182611 5182611 0 0.0
all-clusters-minimal-app debug (read only) 5249761 5249761 0 0.0
(read/write) 238008 238008 0 0.0
.bss 128160 128160 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98296 98296 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290570 290570 0 0.0
.text 4722419 4722419 0 0.0
bridge-app debug (read only) 4640569 4640569 0 0.0
(read/write) 218888 218888 0 0.0
.bss 118688 118688 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87248 87248 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230794 230794 0 0.0
.text 4187427 4187427 0 0.0
chip-tool debug (read only) 12092225 12092225 0 0.0
(read/write) 523456 523456 0 0.0
.bss 95032 95032 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416064 416064 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451673 451673 0 0.0
.text 10931955 10931955 0 0.0
chip-tool-ipv6only arm64 (read only) 11408772 11408772 0 0.0
(read/write) 590952 590952 0 0.0
.bss 104008 104008 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 456016 456016 0 0.0
.dynamic 512 512 0 0.0
.got 17104 17104 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356276 356276 0 0.0
.text 10170600 10170600 0 0.0
lighting-app debug+rpc+ui (read only) 5564233 5564233 0 0.0
(read/write) 227656 227656 0 0.0
.bss 119632 119632 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95616 95616 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354708 354708 0 0.0
.text 4960787 4960787 0 0.0
lock-app debug (read only) 4706417 4706417 0 0.0
(read/write) 206112 206112 0 0.0
.bss 113960 113960 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81256 81256 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 256650 256650 0 0.0
.text 4236483 4236483 0 0.0
ota-provider-app debug (read only) 4315569 4315569 0 0.0
(read/write) 194616 194616 0 0.0
.bss 113760 113760 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70544 70544 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209418 209418 0 0.0
.text 3911379 3911379 0 0.0
ota-requestor-app debug (read only) 4446481 4446481 0 0.0
(read/write) 198984 198984 0 0.0
.bss 114656 114656 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73648 73648 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215530 215530 0 0.0
.text 4031635 4031635 0 0.0
shell debug (read only) 2939033 2939033 0 0.0
(read/write) 157424 157424 0 0.0
.bss 62800 62800 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87400 87400 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 188384 188384 0 0.0
.text 2575250 2575250 0 0.0
thermostat-no-ble arm64 (read only) 4438156 4438156 0 0.0
(read/write) 245752 245752 0 0.0
.bss 122264 122264 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104520 104520 0 0.0
.dynamic 512 512 0 0.0
.got 8720 8720 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160388 160388 0 0.0
.text 3940648 3940648 0 0.0
tv-app debug (read only) 5782849 5782849 0 0.0
(read/write) 353816 353816 0 0.0
.bss 244528 244528 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95432 95432 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295594 295594 0 0.0
.text 5243187 5243187 0 0.0
tv-casting-app debug (read only) 9908481 9908481 0 0.0
(read/write) 343616 343616 0 0.0
.bss 158744 158744 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174960 174960 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 385016 385016 0 0.0
.text 9056275 9056275 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536312 2536312 0 0.0
.bss 220808 220808 0 0.0
.data 5216 5216 0 0.0
.text 1498996 1498996 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1059928 1059928 0 0.0
bss 139171 139171 0 0.0
rodata 101560 101560 0 0.0
text 771904 771904 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1237136 1237136 0 0.0
bss 137443 137443 0 0.0
rodata 151392 151392 0 0.0
text 798268 798268 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1007360 1007360 0 0.0
bss 138029 138029 0 0.0
rodata 88824 88824 0 0.0
text 733216 733216 0 0.0
nxp contact k32w0+release (read only) 575916 575916 0 0.0
(read/write) 83140 83140 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575380 575380 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703300 703300 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589856 589856 0 0.0
light k32w0+release (read only) 609944 609944 0 0.0
(read/write) 82600 82600 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609408 609408 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795208 795208 0 0.0
.bss 80736 80736 0 0.0
.data 2064 2064 0 0.0
.text 673040 673040 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832008 832008 0 0.0
(read/write) 1806396 1806396 0 0.0
.bss 198644 198644 0 0.0
.data 2688 2688 0 0.0
.text 1596676 1596676 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835160 835160 0 0.0
(read/write) 1728284 1728284 0 0.0
.bss 195524 195524 0 0.0
.data 2656 2656 0 0.0
.text 1521716 1521716 0 0.0
light cy8ckit_062s2_43012 (read only) 841880 841880 0 0.0
(read/write) 1647028 1647028 0 0.0
.bss 188988 188988 0 0.0
.data 2472 2472 0 0.0
.text 1447180 1447180 0 0.0
lock cy8ckit_062s2_43012 (read only) 814808 814808 0 0.0
(read/write) 1675692 1675692 0 0.0
.bss 216068 216068 0 0.0
.data 2464 2464 0 0.0
.text 1448772 1448772 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133492 1133492 0 0.0
.bss 102620 102620 0 0.0
.data 856 856 0 0.0
.text 645872 645872 0 0.0
lock-app qpg6105+debug (read/write) 1093460 1093460 0 0.0
.bss 97292 97292 0 0.0
.data 860 860 0 0.0
.text 605844 605844 0 0.0
stm32 light STM32WB5MM-DK (read/write) 605121 605121 0 0.0
.bss 128468 128468 0 0.0
.data 688 688 0 0.0
.rodata 80532 80532 0 0.0
.text 385688 385688 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834134 834134 0 0.0
bss 49852 49852 0 0.0
text 624794 624794 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1097260 1097260 0 0.0
bss 101568 101568 0 0.0
text 798216 798216 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058684 1058684 0 0.0
bss 110016 110016 0 0.0
text 772536 772536 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914268 914268 0 0.0
bss 92772 92772 0 0.0
text 656084 656084 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836154 836154 0 0.0
bss 49896 49896 0 0.0
text 626894 626894 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 937040 937040 0 0.0
bss 77508 77508 0 0.0
text 703622 703622 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090756 1090756 0 0.0
bss 99864 99864 0 0.0
text 794168 794168 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911368 911368 0 0.0
bss 69176 69176 0 0.0
text 660390 660390 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933104 933104 0 0.0
bss 92476 92476 0 0.0
text 675102 675102 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833688 833688 0 0.0
bss 58140 58140 0 0.0
text 623872 623872 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799808 799808 0 0.0
bss 56068 56068 0 0.0
text 598778 598778 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676216 676216 0 0.0
bss 73452 73452 0 0.0
text 461890 461890 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843998 843998 0 0.0
bss 51524 51524 0 0.0
text 633538 633538 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858697 858697 0 0.0
bss 59692 59692 0 0.0
text 642368 642368 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825356 825356 0 0.0
bss 56400 56400 0 0.0
text 618328 618328 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838600 838600 0 0.0
bss 58356 58356 0 0.0
text 626360 626360 0 0.0

@mkardous-silabs mkardous-silabs merged commit 9db03ee into project-chip:master Apr 29, 2024
@mkardous-silabs mkardous-silabs deleted the fix/comments branch April 29, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 andy31415 approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees

No one assigned

Labels

app icd Intermittently Connected Devices protocols review - approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mkardous-silabs @tcarmelveilleux @andy31415 @yunhanw-google @jmartinez-silabs