-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[ICD] Convert TestICDMonitoringTable to gTest #33239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 5 commits into
project-chip:master
from
mkardous-silabs:feature/icd_tests_conversion
Apr 30, 2024
Merged
[ICD] Convert TestICDMonitoringTable to gTest #33239
mergify
merged 5 commits into
project-chip:master
from
mkardous-silabs:feature/icd_tests_conversion
Apr 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
reviewed
Apr 30, 2024
andy31415
reviewed
Apr 30, 2024
|
PR #33239: Size comparison from 416f6a3 to 8012f54 Increases (9 builds for cc13x4_26x4, cc32xx, cyw30739, nxp, psoc6, stm32)
Decreases (2 builds for cc32xx, nxp)
Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nxp, psoc6, stm32, telink)
|
5be75bf to
2a34723
Compare
andy31415
approved these changes
Apr 30, 2024
jmartinez-silabs
approved these changes
Apr 30, 2024
|
PR #33239: Size comparison from 7489e02 to 2a34723 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Apr 30, 2024
|
PR #33239: Size comparison from 7489e02 to 5c25369 Increases above 0.2%:
Increases (62 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (20 builds for bl602, bl702, bl702l, linux, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
fast track
icd
Intermittently Connected Devices
inet
review - pending
test driver
tests
transport
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR starts the transition of the ICD unit tests to gtest - TestICDMonitoringTable is transitionned to gtest in this PR.
app/teststoicd/server/testssince they don't on anything from apps.PR has no underlying behavior changes.
Note to reviewers:
TestICDManager will be converted in a follow up because we need to modify the MessagingContext first.
LoopbackMessagingContexthasCHIP_ERROR SetUpTestSuite()in its class definition that conflicts with the gtest signature that returns void.Added Check-In specific tests behind a define guard for TestICDManager. This allows some of the unit tests to always be run as part of the "main" unit test runs.
TestICDMonitoringTable is now part of the main unit test build since it doesn't need any specific build configuration.
Tests
Unit test themselves to make sure they still pass