Remove event list from generated code #34997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 2 of 89 files. Overall, the semantic diff is 1% smaller than the GitHub diff. File Information
|
|
PR #34997: Size comparison from 4205cc3 to bcb24b3 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Aug 23, 2024
Contributor
|
I really appreciate the separate changesets! |
|
PR #34997: Size comparison from 6f0a70c to 2ff7dc7 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34997: Size comparison from 6f0a70c to d0658b2 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Oct 22, 2024
Contributor
tehampson
left a comment
There was a problem hiding this comment.
Thanks for splitting the various commits. That made it easier to review
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* manual change * zap regen * ifdef some stray event lists * re-zap * one more ifdef * Remove some EVENT_LIST_ defines * Remove event list from ACL test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a HUGE change that stems from a one line deletion. It is split into two commits - one showing the manual change, and the other showing the zap regeneration.
Actual changes:
Other changes are all from zap-regen.