Use standard std::min std::max functions #36065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36065: Size comparison from 9524ac9 to 6e042ef Full report (4 builds for cc32xx, tizen)
|
|
PR #36065: Size comparison from 9524ac9 to c124c41 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nxp, qpg, stm32, tizen)
|
|
PR #36065: Size comparison from 9524ac9 to baa16e8 Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #36065: Size comparison from 9524ac9 to 929ce81 Full report (93 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 15, 2024
tcarmelveilleux
approved these changes
Oct 15, 2024
saurabhst
approved these changes
Oct 15, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Use standard std::min std::max functions * Restyled by clang-format * Convert some more max calls * More updates * Another fix * Add missing include --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no reason to keep custom implementation for min/max
Testing
CI will verify