Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Factor out common parts of list iterators into shared super-classes. #36279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

Factor out common parts of list iterators into shared super-classes. #36279

merged 2 commits into from
Oct 29, 2024

Conversation

@bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Oct 29, 2024

Saves some codesize.

Fixes #36264

@semanticdiff-com
Copy link

semanticdiff-com bot commented Oct 29, 2024

Review changes with SemanticDiff.

@github-actions github-actions bot added the app label Oct 29, 2024
@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

PR #36279: Size comparison from cea1e36 to a002b5f

Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section cea1e36 a002b5f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349984 1349366 -618 -0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647380 647062 -318 -0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 824944 824626 -318 -0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053678 1053616 -62 -0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974462 974400 -62 -0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 836412 836140 -272 -0.0
RAM 123676 123676 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 821832 821776 -56 -0.0
RAM 125556 125556 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 768404 768492 88 0.0
RAM 114048 114048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 752664 752736 72 0.0
RAM 114240 114240 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 626506 625854 -652 -0.1
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 666482 665830 -652 -0.1
RAM 206284 206284 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678381 678101 -280 -0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698233 697953 -280 -0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698233 697953 -280 -0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655161 654881 -280 -0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614829 614653 -176 -0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634457 634281 -176 -0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634457 634281 -176 -0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634181 634157 -24 -0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653897 653865 -32 -0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653897 653865 -32 -0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609445 609445 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629297 629297 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629297 629297 0 0.0
RAM 71412 71412 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1538746 1537500 -1246 -0.1
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1548958 1548126 -832 -0.1
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2735565 2730417 -5148 -0.2
RAM 129520 129520 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6037838 6020138 -17700 -0.3
RAM 523840 523840 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5370462 5357412 -13050 -0.2
RAM 242416 242416 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4703992 4699238 -4754 -0.1
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12979326 12901458 -77868 -0.6
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11114536 11029704 -84832 -0.8
RAM 635408 635408 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11309149 11309049 -100 -0.0
RAM 584954 584954 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4530424 4526292 -4132 -0.1
RAM 205336 205336 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5242917 5238421 -4496 -0.1
RAM 465416 465416 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5645089 5637745 -7344 -0.1
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4752870 4747660 -5210 -0.1
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4379642 4374452 -5190 -0.1
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4518682 4512692 -5990 -0.1
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3064061 3048909 -15152 -0.5
RAM 160368 160368 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4122680 4116056 -6624 -0.2
RAM 242896 242896 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5979365 5970741 -8624 -0.1
RAM 596256 596256 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 1118631 11107437 -78880 -0.7
RAM 694536 694536 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914360 913348 -1012 -0.1
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885896 884792 -1104 -0.1
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847928 847408 -520 -0.1
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582296 582312 16 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596776 596792 16 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 618900 618868 -32 -0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 682992 682952 -40 -0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746576 746568 -8 -0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1643620 1641556 -2064 -0.1
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550588 1549116 -1472 -0.1
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1466564 1465700 -864 -0.1
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464004 1463364 -640 -0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660392 660320 -72 -0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618468 618388 -80 -0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481680 481408 -272 -0.1
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 680902 680834 -68 -0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620500 620460 -40 -0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708438 708294 -144 -0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625344 625096 -248 -0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811354 811106 -248 -0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1720944 1711476 -9468 -0.6
RAM 90108 90108 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18157782 17942318 -215464 -1.2
RAM 7915456 7811480 -103976 -1.3

@woody-apple woody-apple force-pushed the size-optimize-list-iterators branch from a002b5f to b3c9305 Compare October 29, 2024 06:09
@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

PR #36279: Size comparison from c18a6de to b3c9305

Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c18a6de b3c9305 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349984 1349366 -618 -0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647380 647062 -318 -0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 824944 824626 -318 -0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053678 1053616 -62 -0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974462 974400 -62 -0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 836412 836140 -272 -0.0
RAM 123676 123676 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 821832 821776 -56 -0.0
RAM 125556 125556 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 768404 768492 88 0.0
RAM 114048 114048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 752664 752736 72 0.0
RAM 114240 114240 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 626506 625854 -652 -0.1
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 666482 665830 -652 -0.1
RAM 206284 206284 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678381 678101 -280 -0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698233 697953 -280 -0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698233 697953 -280 -0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655161 654881 -280 -0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614829 614653 -176 -0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634457 634281 -176 -0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634457 634281 -176 -0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634181 634157 -24 -0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653897 653865 -32 -0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653897 653865 -32 -0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609445 609445 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629297 629297 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629297 629297 0 0.0
RAM 71412 71412 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1538746 1537500 -1246 -0.1
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1548958 1548126 -832 -0.1
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2737039 2731891 -5148 -0.2
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6039312 6021614 -17698 -0.3
RAM 523872 523872 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5371938 5358888 -13050 -0.2
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4705468 4700714 -4754 -0.1
RAM 218416 218416 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12979326 12901458 -77868 -0.6
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11114536 11029704 -84832 -0.8
RAM 635408 635408 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11309149 11309049 -100 -0.0
RAM 584954 584954 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4531898 4527766 -4132 -0.1
RAM 205400 205400 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5244389 5239893 -4496 -0.1
RAM 465448 465448 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5646593 5639249 -7344 -0.1
RAM 228552 228552 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4754344 4749134 -5210 -0.1
RAM 204536 204536 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4381116 4375926 -5190 -0.1
RAM 198256 198256 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4520156 4514166 -5990 -0.1
RAM 202824 202824 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3064061 3048909 -15152 -0.5
RAM 160368 160368 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4124152 4117528 -6624 -0.2
RAM 242944 242944 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5980805 5972197 -8608 -0.1
RAM 596320 596320 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11187789 11108909 -78880 -0.7
RAM 694568 694568 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914360 913348 -1012 -0.1
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885896 884792 -1104 -0.1
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847928 847408 -520 -0.1
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582296 582312 16 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596776 596792 16 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 618900 618868 -32 -0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 682992 682952 -40 -0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746576 746568 -8 -0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1643620 1641556 -2064 -0.1
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550588 1549116 -1472 -0.1
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1466564 1465700 -864 -0.1
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464004 1463364 -640 -0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660392 660320 -72 -0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618468 618388 -80 -0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481680 481408 -272 -0.1
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 680902 680834 -68 -0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620500 620460 -40 -0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708438 708294 -144 -0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625344 625096 -248 -0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811354 811106 -248 -0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1722356 1712896 -9460 -0.5
RAM 90140 90140 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18157782 17942318 -215464 -1.2
RAM 7915456 7811480 -103976 -1.3

@bzbarsky-apple bzbarsky-apple force-pushed the size-optimize-list-iterators branch from b3c9305 to 0e88bb3 Compare October 29, 2024 16:33
@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

PR #36279: Size comparison from 3d80093 to 0e88bb3

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 3d80093 0e88bb3 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349924 1349306 -618 -0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647346 647028 -318 -0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 824910 824592 -318 -0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053644 1053582 -62 -0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974428 974366 -62 -0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 836396 836124 -272 -0.0
RAM 123676 123676 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 821824 821768 -56 -0.0
RAM 125556 125556 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 768388 768476 88 0.0
RAM 114048 114048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 752648 752720 72 0.0
RAM 114240 114240 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 626450 625798 -652 -0.1
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 666426 665774 -652 -0.1
RAM 206284 206284 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678365 678085 -280 -0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698217 697937 -280 -0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698217 697937 -280 -0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655153 654873 -280 -0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614813 614637 -176 -0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634449 634273 -176 -0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634449 634273 -176 -0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634173 634149 -24 -0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653889 653857 -32 -0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653889 653857 -32 -0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609429 609429 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629281 629281 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629281 629281 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 926100 926068 -32 -0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 741208 740568 -640 -0.1
RAM 232580 232580 0 0.0
window-app BRD4187C FLASH 1018008 1017272 -736 -0.1
RAM 128264 128264 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1538710 1537464 -1246 -0.1
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1548950 1548126 -824 -0.1
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2736743 2731595 -5148 -0.2
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6039048 6021350 -17698 -0.3
RAM 523872 523872 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5371642 5358592 -13050 -0.2
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4705204 4700450 -4754 -0.1
RAM 218400 218400 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12979062 12901194 -77868 -0.6
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11114184 11029352 -84832 -0.8
RAM 635400 635400 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11308853 11308753 -100 -0.0
RAM 584922 584922 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4531634 4527502 -4132 -0.1
RAM 205368 205368 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5244117 5239621 -4496 -0.1
RAM 465432 465432 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5646289 5638961 -7328 -0.1
RAM 228520 228520 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4754080 4748870 -5210 -0.1
RAM 204520 204520 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4380820 4375630 -5190 -0.1
RAM 198240 198240 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4519860 4513870 -5990 -0.1
RAM 202808 202808 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3063773 3048605 -15168 -0.5
RAM 160336 160336 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4123816 4117192 -6624 -0.2
RAM 242936 242936 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5980517 5971893 -8624 -0.1
RAM 596304 596304 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11187469 11108589 -78880 -0.7
RAM 694552 694552 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914348 913336 -1012 -0.1
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885884 884780 -1104 -0.1
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847916 847396 -520 -0.1
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582280 582296 16 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596768 596784 16 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 618884 618852 -32 -0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 682976 682936 -40 -0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746568 746560 -8 -0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1643572 1641508 -2064 -0.1
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550524 1549052 -1472 -0.1
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1466516 1465636 -880 -0.1
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463956 1463300 -656 -0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660376 660304 -72 -0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618460 618380 -80 -0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481672 481392 -280 -0.1
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 680868 680800 -68 -0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620466 620426 -40 -0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708404 708260 -144 -0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625310 625062 -248 -0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811320 811072 -248 -0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1722268 1712792 -9476 -0.6
RAM 90140 90140 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18157678 17942222 -215456 -1.2
RAM 7915516 7811540 -103976 -1.3

@mergify mergify bot merged commit 8211b69 into project-chip:master Oct 29, 2024
67 checks passed
@bzbarsky-apple bzbarsky-apple deleted the size-optimize-list-iterators branch October 29, 2024 20:26
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@bzbarsky-apple @yyzhong-g
Factor out common parts of list iterators into shared super-classes. (p…
011b171 
…roject-chip#36279)

* Factor out common parts of list iterators into shared super-classes.

Saves some codesize.

Fixes project-chip#36264

* Remove unused variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

Assignees

No one assigned

Labels

app controller review - approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature] may save more flash by splitting list iterator templates even more

3 participants

@bzbarsky-apple @andy31415 @woody-apple