[Matter.framework] Invalidate the CASE session if something calls Tri… #36298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggerResubscriptionWithReason and it has not been established yet
|
Review changes with |
|
PR #36298: Size comparison from 7df7676 to ec2ff36 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Oct 30, 2024
| #endif // CHIP_DEVICE_CONFIG_ENABLE_AUTOMATIC_CASE_RETRIES | ||
| TransportPayloadCapability transportPayloadCapability = TransportPayloadCapability::kMRPPayload); | ||
|
|
||
| void ReleaseSession(const ScopedNodeId & peerId); |
| caseSessionMgr->ReleaseSession(self->_cppCommissioner->GetPeerScopedId(nodeID.unsignedLongLongValue)); | ||
| }; | ||
|
|
||
| [self syncRunOnWorkQueue:block error:nil]; |
Contributor
There was a problem hiding this comment.
Why do we need a sync dispatch here?
| // If we have reason to suspect that the node is now reachable and we haven’t established a | ||
| // CASE session yet, let’s consider it to be stalled and invalidate the pairing session. | ||
| dispatch_async(self.queue, ^{ | ||
| [[self _concreteController] invalidateCASESessionEstablishmentForNode:self->_nodeID]; |
Contributor
There was a problem hiding this comment.
We shouldn't add new controller API here, I would think. Just asyncGetCommissionerOnMatterQueue and go from there.
That said, do we have any indication that we are not just going to get a slew of _triggerResubscribeWithReason from DNS-SD stuff while nothing has really changed? I'm really worried about us getting into a state where we just keep canceling things and never manage to subscribe. It does help that we only do this when we have no CASE session yet, at least....
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ggerResubscriptionWithReason and it has not been established yet (project-chip#36298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ggerResubscriptionWithReason and it has not been established yet
Problem
When setting up the initial subscription and it appears to be stuck, let’s cancel the session establishment. This will cause the session to fail, and the error will be caught by the following GitHub repository:
connectedhomeip/src/darwin/Framework/CHIP/MTRDevice_Concrete.mm
Line 2456 in 7df7676