Add a helper function to allow ErrorStr not using static char array #36391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
arkq
reviewed
Nov 6, 2024
|
PR #36391: Size comparison from da2b767 to 17d453c Full report (20 builds for linux, stm32, tizen)
|
andy31415
reviewed
Nov 6, 2024
andy31415
reviewed
Nov 6, 2024
andy31415
previously requested changes
Nov 6, 2024
Contributor
andy31415
left a comment
There was a problem hiding this comment.
Please add unit tests as well
|
PR #36391: Size comparison from da2b767 to 246e29b Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Nov 7, 2024
andy31415
approved these changes
Nov 7, 2024
|
PR #36391: Size comparison from da2b767 to c67ac81 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36391: Size comparison from e338404 to 8b8d037 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Nov 8, 2024
yyzhong-g
added a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#36391) * Add a helper function to allow ErrorStr does not rely on static char array * Use dedicated storage for ErrorStr and add unit tests * Restyled by whitespace * Restyled by clang-format * remove size() --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide another ErrorStr function that enable user to specify the buffer they writes to.
Using a static char array for writing the error str causes the data race when there is more than one thread.