[Zephyr] Add implementation of POSIX API wrappers if necessary #37007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
f53c48f to
be25c9f
Compare
825b220 to
5e3d939
Compare
andy31415
requested changes
Jan 9, 2025
Contributor
andy31415
left a comment
There was a problem hiding this comment.
Please add a ### Testing section describing how things were tested that this still works? What commands did you run (assuming manual testing) and what was observed. Did you test all affected platforms or only one/some and assumed the changes will work everywhere? Are all platform owners of the affected platforms aware of the change?
f27d1c7 to
32c30cd
Compare
Contributor
Author
Hi @andy31415 , sure, added a section in PR comment. I had to change the approach and keep |
|
PR #37007: Size comparison from 5bd63d5 to 32c30cd Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
Damian-Nordic
approved these changes
Jan 14, 2025
`CONFIG_NET_SOCKETS_POSIX_NAMES` has been deprecated in Zephyr in favor of `CONFIG_POSIX_API`. `CONFIG_POSIX_API` enables additional functionalities other than sockets, resulting in increased footprint. This commit extends `ZephyrSocket.h` to include Zephyr socket header and allow building with both configs disabled, adding neccessary wrappers.
32c30cd to
10518d5
Compare
|
PR #37007: Size comparison from a5bf60d to 10518d5 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jan 16, 2025
maciejbaczmanski
added a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jan 30, 2025
…cessary (project-chip#37007) `CONFIG_NET_SOCKETS_POSIX_NAMES` has been deprecated in Zephyr in favor of `CONFIG_POSIX_API`. `CONFIG_POSIX_API` enables additional functionalities other than sockets, resulting in increased footprint. This commit extends `ZephyrSocket.h` to include Zephyr socket header and allow building with both configs disabled, adding neccessary wrappers. (cherry picked from commit 2a09f8b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONFIG_NET_SOCKETS_POSIX_NAMEShas been deprecated in Zephyrin favor of
CONFIG_POSIX_API.CONFIG_POSIX_APIenables additional functionalities other thansockets, resulting in increased footprint.
This commit extends
ZephyrSocket.hto include Zephyr socketheader and allow building with both configs disabled, adding
neccessary wrappers.
Testing
Tested manually on nRF SoC as nordic is the only affected platform (all other platforms use
CONFIG_POSIX_API)