Use separate randomized port for each TCP test case server listening. #37144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Previously, all test cases in a single test run were using the same random port, and it caused some flakiness because sometimes the kernel could still be holding on to the previous test case port and, as a result, the next test case failed to bind throwing an "Address Already In Use" error.
0a0dde1 to
dfe1ac8
Compare
|
PR #37144: Size comparison from bdbd217 to dfe1ac8 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jan 21, 2025
andy31415
approved these changes
Jan 22, 2025
yufengwangca
approved these changes
Jan 22, 2025
aronrosenberg
approved these changes
Jan 22, 2025
andy31415
pushed a commit
that referenced
this pull request
May 7, 2025
Previously, all test cases in a single test run were using the same random port, and it caused some flakiness because sometimes the kernel could still be holding on to the previous test case port and, as a result, the next test case failed to bind throwing an "Address Already In Use" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid any port binding conflicts between test cases.
Previously, all test cases in a single test run were using the same
random port, and it caused some flakiness because sometimes the kernel
could still be holding on to the previous test case port and, as a
result, the next test case failed to bind throwing an "Address Already
In Use" error.
Testing
TCP unit tests