Clarify logging during MRP retransmit backoff computation. #37369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log sounded like a retransmit was happening, but it's actually saying that a retransmit is scheduled. The retransmit might or might not happen, depending on whether we get an ack before the scheduled time.
|
Review changes with |
|
PR #37369: Size comparison from 0d27f42 to 7cb5a0f Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Feb 4, 2025
shubhamdp
approved these changes
Feb 4, 2025
adigie
pushed a commit
to adigie/connectedhomeip
that referenced
this pull request
Feb 4, 2025
…hip#37369) The log sounded like a retransmit was happening, but it's actually saying that a retransmit is scheduled. The retransmit might or might not happen, depending on whether we get an ack before the scheduled time.
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Feb 12, 2025
…hip#37369) The log sounded like a retransmit was happening, but it's actually saying that a retransmit is scheduled. The retransmit might or might not happen, depending on whether we get an ack before the scheduled time.
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Feb 28, 2025
…hip#37369) The log sounded like a retransmit was happening, but it's actually saying that a retransmit is scheduled. The retransmit might or might not happen, depending on whether we get an ack before the scheduled time.
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…hip#37369) The log sounded like a retransmit was happening, but it's actually saying that a retransmit is scheduled. The retransmit might or might not happen, depending on whether we get an ack before the scheduled time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log sounded like a retransmit was happening, but it's actually saying that a retransmit is scheduled. The retransmit might or might not happen, depending on whether we get an ack before the scheduled time.
Testing
Logging change only.