Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PASESession] TLV Reading Fixes #37383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2025
Merged

[PASESession] TLV Reading Fixes #37383

merged 3 commits into from
Feb 14, 2025

Conversation

@Alami-Amine
Copy link
Contributor

@Alami-Amine Alami-Amine commented Feb 4, 2025 •
edited
Loading

  1. Fixes TLV Reading of Containers often missed a call to ExitContainer #36959 : Making sure received encoded messages are properly terminated.

  2. Adding Sanity Checks that the read TLV data has the expected number of bytes:

  3. Adding symbolic TLV Tags

Testing

  • Unit Tests with ASAN
  • FuzzTests using pw_fuzzer

@semanticdiff-com
Copy link

semanticdiff-com bot commented Feb 4, 2025

Review changes with  SemanticDiff

@github-actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

PR #37383: Size comparison from f957643 to 59363de

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section f957643 59363de change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093988 1094160 172 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650600 650772 172 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828508 828680 172 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057068 1057240 172 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888502 888674 172 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971488 971660 172 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838160 838356 196 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823564 823760 196 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770836 771032 196 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755088 755284 196 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538637 538841 204 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572493 572697 204 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679601 679801 200 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699445 699645 200 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699445 699645 200 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656389 656589 200 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615977 616185 208 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635613 635821 208 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635613 635821 208 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635457 635665 208 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655165 655373 208 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655165 655373 208 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611893 612101 208 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631753 631961 208 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631753 631961 208 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936440 936632 192 0.0
RAM 159872 159872 0 0.0
BRD4338a FLASH 730356 730508 152 0.0
RAM 234700 234700 0 0.0
window-app BRD4187C FLASH 1029712 1029872 160 0.0
RAM 127976 127976 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1577564 1577742 178 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1545178 1545354 176 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2710221 2711177 956 0.0
RAM 132816 132816 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5976202 5977160 958 0.0
RAM 531632 531632 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5324888 5325846 958 0.0
RAM 242744 242744 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4683142 4684100 958 0.0
RAM 221480 221480 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099998 13100956 958 0.0
RAM 596770 596770 0 0.0
chip-tool-ipv6only arm64 unknown 21848 21848 0 0.0
FLASH 11163616 11164368 752 0.0
RAM 648448 648448 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11389471 11390429 958 0.0
RAM 596554 596554 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4507708 4508666 958 0.0
RAM 208664 208664 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5614085 5615045 960 0.0
RAM 483536 483536 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5625841 5626801 960 0.0
RAM 231760 231760 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4732256 4733214 958 0.0
RAM 207728 207728 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360768 4361726 958 0.0
RAM 201368 201368 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4498240 4499198 958 0.0
RAM 205952 205952 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3006141 3007101 960 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098176 4098928 752 0.0
RAM 246096 246096 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5953717 5954677 960 0.0
RAM 606936 606936 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11273581 11274525 944 0.0
RAM 710896 710896 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907196 907392 196 0.0
RAM 142395 142395 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901824 901984 160 0.0
RAM 124739 124739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845920 846116 196 0.0
RAM 141323 141323 0 0.0
nxp contact k32w0+release FLASH 584496 584688 192 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599832 600024 192 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610940 611132 192 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685368 685560 192 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748848 749048 200 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646844 1647020 176 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553612 1553788 176 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1469292 1469468 176 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467340 1467500 160 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 662232 662432 200 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 620004 620204 200 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482824 483020 196 0.0
RAM 144672 144672 0 0.0
telink bridge-app tl7218x FLASH 665242 665416 174 0.0
RAM 90812 90812 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622000 622174 174 0.0
RAM 31484 31484 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770754 770928 174 0.0
RAM 43552 43552 0 0.0
tl7218x FLASH 779284 779458 174 0.0
RAM 98688 98688 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680618 680792 174 0.0
RAM 52176 52176 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709172 709346 174 0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626086 626260 174 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813468 813642 174 0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1752956 1753452 496 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11408 11408 0 0.0
FLASH 18699718 18701094 1376 0.0
RAM 8184616 8185116 500 0.0

@Alami-Amine Alami-Amine changed the title [PASESession] TLV Reading Fixes in PASESession [PASESession] TLV Reading Fixes Feb 4, 2025
yunhanw-google
yunhanw-google reviewed Feb 4, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

PR #37383: Size comparison from 577b3f2 to fa04a11

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 577b3f2 fa04a11 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093988 1094160 172 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650600 650772 172 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828508 828680 172 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057068 1057240 172 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888502 888674 172 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971488 971660 172 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838160 838356 196 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823564 823760 196 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770836 771032 196 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755088 755284 196 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538637 538841 204 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572493 572697 204 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679601 679801 200 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699445 699645 200 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699445 699645 200 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656389 656589 200 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615977 616185 208 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635613 635821 208 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635613 635821 208 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635457 635665 208 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655165 655373 208 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655165 655373 208 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611893 612101 208 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631753 631961 208 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631753 631961 208 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936440 936632 192 0.0
RAM 159872 159872 0 0.0
BRD4338a FLASH 730356 730508 152 0.0
RAM 234700 234700 0 0.0
window-app BRD4187C FLASH 1029712 1029872 160 0.0
RAM 127976 127976 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1577564 1577742 178 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1545178 1545354 176 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2710221 2711177 956 0.0
RAM 132816 132816 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5976202 5977160 958 0.0
RAM 531632 531632 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5324888 5325846 958 0.0
RAM 242744 242744 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4683142 4684100 958 0.0
RAM 221480 221480 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099998 13100956 958 0.0
RAM 596770 596770 0 0.0
chip-tool-ipv6only arm64 unknown 21848 21848 0 0.0
FLASH 11163616 11164368 752 0.0
RAM 648448 648448 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11389471 11390429 958 0.0
RAM 596554 596554 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4507708 4508666 958 0.0
RAM 208664 208664 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5614085 5615045 960 0.0
RAM 483536 483536 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5625841 5626801 960 0.0
RAM 231760 231760 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4732256 4733214 958 0.0
RAM 207728 207728 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360768 4361726 958 0.0
RAM 201368 201368 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4498240 4499198 958 0.0
RAM 205952 205952 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3006141 3007101 960 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098176 4098928 752 0.0
RAM 246096 246096 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5953717 5954677 960 0.0
RAM 606936 606936 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11273581 11274525 944 0.0
RAM 710896 710896 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907196 907392 196 0.0
RAM 142395 142395 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901824 901984 160 0.0
RAM 124739 124739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845920 846116 196 0.0
RAM 141323 141323 0 0.0
nxp contact k32w0+release FLASH 584496 584688 192 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599832 600024 192 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610940 611132 192 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685368 685560 192 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748848 749048 200 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646844 1647020 176 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553612 1553788 176 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1469292 1469468 176 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467340 1467500 160 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 662232 662432 200 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 620004 620204 200 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482824 483020 196 0.0
RAM 144672 144672 0 0.0
telink bridge-app tl7218x FLASH 665242 665416 174 0.0
RAM 90812 90812 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622000 622174 174 0.0
RAM 31484 31484 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770754 770928 174 0.0
RAM 43552 43552 0 0.0
tl7218x FLASH 779284 779458 174 0.0
RAM 98688 98688 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680618 680792 174 0.0
RAM 52176 52176 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709172 709346 174 0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626086 626260 174 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813468 813642 174 0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1752956 1753452 496 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11408 11408 0 0.0
FLASH 18699718 18701094 1376 0.0
RAM 8184616 8185116 500 0.0

andy31415
andy31415 reviewed Feb 6, 2025
View reviewed changes
andy31415
andy31415 reviewed Feb 6, 2025
View reviewed changes
tehampson
tehampson reviewed Feb 6, 2025
View reviewed changes
@Alami-Amine Alami-Amine force-pushed the AA/PaseTLVFixes branch 2 times, most recently from 3a79525 to 843836f Compare February 6, 2025 16:25
@github-actions
Copy link

github-actions bot commented Feb 6, 2025 •
edited
Loading

PR #37383: Size comparison from 8ec9b41 to 843836f

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8ec9b41 843836f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094024 1094058 34 0.0
RAM 103314 103314 0 0.0
bl702 lighting-app bl702+eth FLASH 650542 650576 34 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828506 828540 34 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057066 1057100 34 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888444 888478 34 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971486 971520 34 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838240 838320 80 0.0
RAM 123480 123480 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823644 823724 80 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770820 770900 80 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755088 755168 80 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538621 538717 96 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572493 572589 96 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679585 679681 96 0.0
RAM 78548 78548 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699429 699525 96 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699429 699525 96 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656365 656461 96 0.0
RAM 73616 73616 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615945 616041 96 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635573 635669 96 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635573 635669 96 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635449 635545 96 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655157 655253 96 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655157 655253 96 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611861 611957 96 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631721 631817 96 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631721 631817 96 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 936408 936504 96 0.0
RAM 159872 159872 0 0.0
BRD4338a FLASH 730348 730412 64 0.0
RAM 234716 234716 0 0.0
window-app BRD4187C FLASH 1029656 1029720 64 0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1577420 1577464 44 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1545326 1545410 84 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2709171 2709465 294 0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5975584 5975880 296 0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5323948 5324244 296 0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4682560 4682856 296 0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099268 13099564 296 0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11162800 11163104 304 0.0
RAM 648256 648280 24 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11388297 11388593 296 0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4507818 4508114 296 0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5614085 5614389 304 0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5625217 5625521 304 0.0
RAM 231728 231728 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4731186 4731482 296 0.0
RAM 207696 207696 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360136 4360432 296 0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4497640 4497936 296 0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3005709 3005997 288 0.0
RAM 160472 160472 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097192 4097496 304 0.0
RAM 246024 246048 24 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5952965 5953269 304 0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11272797 11273101 304 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907288 907380 92 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901980 902020 40 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845896 845984 88 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584624 584704 80 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 599936 600016 80 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 610932 611028 96 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685336 685416 80 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 748832 748912 80 0.0
RAM 67492 67492 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646740 1646804 64 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553628 1553692 64 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1469356 1469420 64 0.0
RAM 200368 200368 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467308 1467372 64 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662216 662304 88 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 619996 620084 88 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 482872 482960 88 0.0
RAM 144688 144688 0 0.0
telink bridge-app tl7218x FLASH 665258 665298 40 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622020 622060 40 0.0
RAM 31500 31500 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770804 770844 40 0.0
RAM 43568 43568 0 0.0
tl7218x FLASH 779306 779346 40 0.0
RAM 98704 98704 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680618 680658 40 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709172 709212 40 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626108 626148 40 0.0
RAM 142032 142032 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813492 813532 40 0.0
RAM 99576 99576 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752232 1752348 116 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18696694 18696622 -72 -0.0
RAM 8182536 8182644 108 0.0

@Alami-Amine Alami-Amine linked an issue Feb 6, 2025 that may be closed by this pull request
CASESession.cpp and PASESession.cpp should be using named tag #30476
Closed
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

PR #37383: Size comparison from 1b3f616 to a393024

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 1b3f616 a393024 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1095960 1095994 34 0.0
RAM 94906 94906 0 0.0
bl702 lighting-app bl702+eth FLASH 652080 652114 34 0.0
RAM 33633 33633 0 0.0
bl702+wifi FLASH 828572 828606 34 0.0
RAM 22341 22341 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061718 1061752 34 0.0
RAM 32285 32285 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892592 892626 34 0.0
RAM 26912 26912 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975962 975996 34 0.0
RAM 24752 24752 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815204 815284 80 0.0
RAM 120352 120352 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823832 823912 80 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770992 771072 80 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755260 755340 80 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538894 538990 96 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572766 572862 96 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656501 656597 96 0.0
RAM 75420 75420 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676361 676457 96 0.0
RAM 78060 78060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676361 676457 96 0.0
RAM 78060 78060 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633285 633381 96 0.0
RAM 70488 70488 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616117 616213 96 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635753 635849 96 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635753 635849 96 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635621 635717 96 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655337 655433 96 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655337 655433 96 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611969 612065 96 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631829 631925 96 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631829 631925 96 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937264 937360 96 0.0
RAM 159908 159908 0 0.0
BRD4338a FLASH 730592 730648 56 0.0
RAM 234720 234720 0 0.0
window-app BRD4187C FLASH 1029856 1029920 64 0.0
RAM 128012 128012 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1581680 1581724 44 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1549606 1549702 96 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4712 4712 0 0.0
FLASH 2648901 2649195 294 0.0
RAM 111600 111600 0 0.0
all-clusters-app debug unknown 5520 5520 0 0.0
FLASH 5915332 5915628 296 0.0
RAM 510416 510416 0 0.0
all-clusters-minimal-app debug unknown 5416 5416 0 0.0
FLASH 5262876 5263172 296 0.0
RAM 221528 221528 0 0.0
bridge-app debug unknown 5432 5432 0 0.0
FLASH 4621552 4621848 296 0.0
RAM 200264 200264 0 0.0
chip-tool debug unknown 6088 6088 0 0.0
FLASH 13071206 13071502 296 0.0
RAM 596482 596482 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11137776 11138080 304 0.0
RAM 648160 648184 24 0.0
fabric-admin debug unknown 5776 5776 0 0.0
FLASH 11359987 11360283 296 0.0
RAM 596266 596266 0 0.0
fabric-bridge-app debug unknown 4680 4680 0 0.0
FLASH 4446874 4447170 296 0.0
RAM 187480 187480 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5563813 5564101 288 0.0
RAM 467024 467024 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5424673 5424961 288 0.0
RAM 204208 204208 0 0.0
lock-app debug unknown 5384 5384 0 0.0
FLASH 4681596 4681892 296 0.0
RAM 191216 191216 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4299982 4300278 296 0.0
RAM 180184 180184 0 0.0
ota-requestor-app debug unknown 4672 4672 0 0.0
FLASH 4437358 4437654 296 0.0
RAM 184768 184768 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2950060 2950364 304 0.0
RAM 144040 144040 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4039880 4040184 304 0.0
RAM 228528 228552 24 0.0
tv-app debug unknown 5712 5712 0 0.0
FLASH 5902693 5902981 288 0.0
RAM 590424 590424 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11243757 11244045 288 0.0
RAM 710640 710640 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907464 907556 92 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901920 901960 40 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846084 846172 88 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584752 584848 96 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600208 600288 80 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611076 611156 80 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685512 685592 80 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749024 749104 80 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646756 1646820 64 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553524 1553588 64 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1439196 1439260 64 0.0
RAM 197144 197144 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467412 1467476 64 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662340 662428 88 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620136 620224 88 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459736 459824 88 0.0
RAM 141568 141568 0 0.0
telink bridge-app tl7218x FLASH 665226 665266 40 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621908 621948 40 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745418 745458 40 0.0
RAM 40496 40496 0 0.0
tl7218x FLASH 753974 754014 40 0.0
RAM 97632 97632 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680678 680718 40 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709240 709280 40 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600796 600836 40 0.0
RAM 138912 138912 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788928 788968 40 0.0
RAM 96488 96488 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1751708 1751824 116 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18683334 18683262 -72 -0.0
RAM 8181084 8181192 108 0.0

@mergify mergify bot merged commit 9e94a9f into project-chip:master Feb 14, 2025
70 checks passed
ratgr pushed a commit to ratgr/connectedhomeip that referenced this pull request Feb 26, 2025
@Alami-Amine @ratgr
[PASESession] TLV Reading Fixes (project-chip#37383)
1172e1f 
* Adding missing ExitContainer calls and adding GetLength Checks

* Adding Symbolic TLV Tags

* Integrating Comments
gmarcosb pushed a commit to gmarcosb/connectedhomeip that referenced this pull request Mar 4, 2025
@Alami-Amine @gmarcosb
[PASESession] TLV Reading Fixes (project-chip#37383)
912d929 
* Adding missing ExitContainer calls and adding GetLength Checks

* Adding Symbolic TLV Tags

* Integrating Comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy31415 andy31415 andy31415 approved these changes

@tehampson tehampson tehampson approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

Assignees

No one assigned

Labels

protocols review - approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TLV Reading of Containers often missed a call to ExitContainer CASESession.cpp and PASESession.cpp should be using named tag

5 participants

@Alami-Amine @andy31415 @tehampson @yunhanw-google @jmartinez-silabs