[PSA] bugfix for potential buffer overflow from AES_CCM Encrypt/Decrypt #37337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37337: Size comparison from 4f956ec to 91eb157 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37337: Size comparison from 4f956ec to 1ad25a8 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Jan 31, 2025
Damian-Nordic
approved these changes
Feb 3, 2025
|
PR #37337: Size comparison from 4f956ec to 69d5de5 Full report (8 builds for nrfconnect, nxp)
|
69d5de5 to
9f96d34
Compare
|
PR #37337: Size comparison from 0d27f42 to 9f96d34 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Feb 6, 2025
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Feb 12, 2025
…pt (project-chip#37337) * [PSA] bugfix for potential buffer overflow from AES_CCM Encrypt/Decrypt * Integrating Comments * Integrating comments
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Feb 28, 2025
…pt (project-chip#37337) * [PSA] bugfix for potential buffer overflow from AES_CCM Encrypt/Decrypt * Integrating Comments * Integrating comments
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…pt (project-chip#37337) * [PSA] bugfix for potential buffer overflow from AES_CCM Encrypt/Decrypt * Integrating Comments * Integrating comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [BUG] [PSA] Output buffer provided to AES_CCM_decrypt might not be wide enough #35155
before this fix, buffer overflow could occur in encryption and decryption operations when the input buffer's size wasn't a multiple of 16 bytes (AES block size).
This happened because PSA's
psa_aead_updateAPI requires output buffers to be block-aligned. So they were rounded up to multiples of 16 bytes in the API Call.Testing
Tested using
scripts/build/build_examples.py --target nrf-native-posix-64-tests buildwhich uses Crypto PSA on Linux