Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Inet] fix UDP bind with OT stack sha 473af53 and newer #37579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

[Inet] fix UDP bind with OT stack sha 473af53 and newer #37579

merged 2 commits into from
Feb 18, 2025

Conversation

@marius-preda
Copy link
Contributor

@marius-preda marius-preda commented Feb 14, 2025 •
edited by andy31415
Loading

This commit fixes Matter over Thread build when using Openthread Thread stack version 473af53 and newer.

Testing

Tested build on K32W1 with Openthread commit 473af53.

@semanticdiff-com
Copy link

semanticdiff-com bot commented Feb 14, 2025

Review changes with  SemanticDiff

@github-actions github-actions bot added the inet label Feb 14, 2025
@marius-preda
[Inet] fix UDP bind with OT stack sha 473af53 and newer
25da727 
Testing:
Tested build on NXP K32W1 with Openthread commit 473af53.

Signed-off-by: Marius Preda <[email protected]>
@marius-preda marius-preda force-pushed the fix_MOT_with_new_ot_stack branch from 683e129 to 25da727 Compare February 14, 2025 10:24
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

PR #37579: Size comparison from 1b3f616 to 25da727

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 1b3f616 25da7279 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1095960 1095960 0 0.0
RAM 94906 94906 0 0.0
bl702 lighting-app bl702+eth FLASH 652080 652080 0 0.0
RAM 33633 33633 0 0.0
bl702+wifi FLASH 828572 828572 0 0.0
RAM 22341 22341 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061718 1061718 0 0.0
RAM 32285 32285 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892592 892592 0 0.0
RAM 26912 26912 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975962 975962 0 0.0
RAM 24752 24752 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815204 815204 0 0.0
RAM 120352 120352 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823832 823832 0 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770992 770992 0 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755260 755260 0 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538894 538894 0 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572766 572766 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656501 656501 0 0.0
RAM 75420 75420 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676361 676361 0 0.0
RAM 78060 78060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676361 676361 0 0.0
RAM 78060 78060 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633285 633285 0 0.0
RAM 70488 70488 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616117 616117 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635753 635753 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635753 635753 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635621 635621 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655337 655337 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655337 655337 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611969 611969 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631829 631829 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631829 631829 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937264 937264 0 0.0
RAM 159908 159908 0 0.0
BRD4338a FLASH 730592 730584 -8 -0.0
RAM 234720 234720 0 0.0
window-app BRD4187C FLASH 1029856 1029856 0 0.0
RAM 128012 128012 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1581680 1581680 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1549606 1549606 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4712 4712 0 0.0
FLASH 2648901 2648901 0 0.0
RAM 111600 111600 0 0.0
all-clusters-app debug unknown 5520 5520 0 0.0
FLASH 5915332 5915332 0 0.0
RAM 510416 510416 0 0.0
all-clusters-minimal-app debug unknown 5416 5416 0 0.0
FLASH 5262876 5262876 0 0.0
RAM 221528 221528 0 0.0
bridge-app debug unknown 5432 5432 0 0.0
FLASH 4621552 4621552 0 0.0
RAM 200264 200264 0 0.0
chip-tool debug unknown 6088 6088 0 0.0
FLASH 13071206 13071206 0 0.0
RAM 596482 596482 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11137776 11137776 0 0.0
RAM 648160 648160 0 0.0
fabric-admin debug unknown 5776 5776 0 0.0
FLASH 11359987 11359987 0 0.0
RAM 596266 596266 0 0.0
fabric-bridge-app debug unknown 4680 4680 0 0.0
FLASH 4446874 4446874 0 0.0
RAM 187480 187480 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5563813 5563813 0 0.0
RAM 467024 467024 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5424673 5424673 0 0.0
RAM 204208 204208 0 0.0
lock-app debug unknown 5384 5384 0 0.0
FLASH 4681596 4681596 0 0.0
RAM 191216 191216 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4299982 4299982 0 0.0
RAM 180184 180184 0 0.0
ota-requestor-app debug unknown 4672 4672 0 0.0
FLASH 4437358 4437358 0 0.0
RAM 184768 184768 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2950060 2950060 0 0.0
RAM 144040 144040 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4039880 4039880 0 0.0
RAM 228528 228528 0 0.0
tv-app debug unknown 5712 5712 0 0.0
FLASH 5902693 5902693 0 0.0
RAM 590424 590424 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11243757 11243757 0 0.0
RAM 710640 710640 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907464 907464 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901920 901920 0 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846084 846084 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584752 584752 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600208 600208 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611076 611076 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685512 685512 0 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749024 749024 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646756 1646756 0 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553524 1553524 0 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1439196 1439196 0 0.0
RAM 197144 197144 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467412 1467412 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662340 662340 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620136 620136 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459736 459736 0 0.0
RAM 141568 141568 0 0.0
telink bridge-app tl7218x FLASH 665226 665226 0 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621908 621908 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745418 745418 0 0.0
RAM 40496 40496 0 0.0
tl7218x FLASH 753974 753974 0 0.0
RAM 97632 97632 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680678 680678 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709240 709240 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600796 600796 0 0.0
RAM 138912 138912 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788928 788928 0 0.0
RAM 96488 96488 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1751708 1751708 0 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18683334 18683334 0 0.0
RAM 8181084 8181084 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

PR #37579: Size comparison from 0ed1d14 to abd46df

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 0ed1d14 abd46df change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1095586 1095586 0 0.0
RAM 94890 94890 0 0.0
bl702 lighting-app bl702+eth FLASH 652030 652030 0 0.0
RAM 33617 33617 0 0.0
bl702+wifi FLASH 828194 828194 0 0.0
RAM 22325 22325 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061358 1061358 0 0.0
RAM 32269 32269 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892066 892066 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975438 975438 0 0.0
RAM 24736 24736 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815548 815548 0 0.0
RAM 120352 120352 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824176 824176 0 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771328 771328 0 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755604 755604 0 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 539042 539042 0 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572906 572906 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656685 656685 0 0.0
RAM 75420 75420 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676545 676545 0 0.0
RAM 78060 78060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676545 676545 0 0.0
RAM 78060 78060 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633469 633469 0 0.0
RAM 70488 70488 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616237 616237 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635873 635873 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635873 635873 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635733 635733 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655449 655449 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655449 655449 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612081 612081 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631941 631941 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631941 631941 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937712 937712 0 0.0
RAM 159916 159916 0 0.0
BRD4338a FLASH 731680 731680 0 0.0
RAM 234772 234772 0 0.0
window-app BRD4187C FLASH 1030304 1030304 0 0.0
RAM 128020 128020 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1581862 1581862 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1549842 1549842 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4712 4712 0 0.0
FLASH 2649155 2649155 0 0.0
RAM 111600 111600 0 0.0
all-clusters-app debug unknown 5520 5520 0 0.0
FLASH 5915588 5915588 0 0.0
RAM 510416 510416 0 0.0
all-clusters-minimal-app debug unknown 5416 5416 0 0.0
FLASH 5263132 5263132 0 0.0
RAM 221528 221528 0 0.0
bridge-app debug unknown 5432 5432 0 0.0
FLASH 4621808 4621808 0 0.0
RAM 200264 200264 0 0.0
chip-tool debug unknown 6088 6088 0 0.0
FLASH 13071462 13071462 0 0.0
RAM 596482 596482 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11138016 11138016 0 0.0
RAM 648184 648184 0 0.0
fabric-admin debug unknown 5776 5776 0 0.0
FLASH 11360243 11360243 0 0.0
RAM 596266 596266 0 0.0
fabric-bridge-app debug unknown 4680 4680 0 0.0
FLASH 4447130 4447130 0 0.0
RAM 187480 187480 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5564069 5564069 0 0.0
RAM 467024 467024 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5424929 5424929 0 0.0
RAM 204208 204208 0 0.0
lock-app debug unknown 5384 5384 0 0.0
FLASH 4681852 4681852 0 0.0
RAM 191216 191216 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4300238 4300238 0 0.0
RAM 180184 180184 0 0.0
ota-requestor-app debug unknown 4672 4672 0 0.0
FLASH 4437614 4437614 0 0.0
RAM 184768 184768 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2950316 2950316 0 0.0
RAM 144040 144040 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4040120 4040120 0 0.0
RAM 228552 228552 0 0.0
tv-app debug unknown 5712 5712 0 0.0
FLASH 5902933 5902933 0 0.0
RAM 590424 590424 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11244013 11244013 0 0.0
RAM 710640 710640 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907640 907640 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901944 901944 0 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846256 846256 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 585152 585152 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600632 600632 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611460 611460 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685936 685936 0 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749456 749456 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646836 1646836 0 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553604 1553604 0 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1439276 1439276 0 0.0
RAM 197144 197144 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467492 1467492 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662444 662444 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620240 620240 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 460088 460088 0 0.0
RAM 141568 141568 0 0.0
telink bridge-app tl7218x FLASH 665304 665304 0 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621986 621986 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745488 745488 0 0.0
RAM 40496 40496 0 0.0
tl7218x FLASH 754050 754050 0 0.0
RAM 97632 97632 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680754 680754 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709316 709316 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600862 600862 0 0.0
RAM 138912 138912 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 789004 789004 0 0.0
RAM 96488 96488 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1751800 1751800 0 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18683526 18683526 0 0.0
RAM 8181404 8181404 0 0.0

@mergify mergify bot merged commit 409ad66 into project-chip:master Feb 18, 2025
71 checks passed
@marius-preda marius-preda deleted the fix_MOT_with_new_ot_stack branch February 19, 2025 06:45
ratgr pushed a commit to ratgr/connectedhomeip that referenced this pull request Feb 26, 2025
@marius-preda @chapongatien @ratgr
[Inet] fix UDP bind with OT stack sha 473af53 and newer (project-chip…
7423fdb 
…#37579)

Testing:
Tested build on NXP K32W1 with Openthread commit 473af53.

Signed-off-by: Marius Preda <[email protected]>
Co-authored-by: Gatien Chapon <[email protected]>
gmarcosb pushed a commit to gmarcosb/connectedhomeip that referenced this pull request Mar 4, 2025
@marius-preda @chapongatien @gmarcosb
[Inet] fix UDP bind with OT stack sha 473af53 and newer (project-chip…
b996e79 
…#37579)

Testing:
Tested build on NXP K32W1 with Openthread commit 473af53.

Signed-off-by: Marius Preda <[email protected]>
Co-authored-by: Gatien Chapon <[email protected]>
juandediosg pushed a commit to juandediosg/connectedhomeip that referenced this pull request Mar 28, 2025
@marius-preda @chapongatien @juandediosg
[Inet] fix UDP bind with OT stack sha 473af53 and newer (project-chip…
46b4485 
…#37579)

Testing:
Tested build on NXP K32W1 with Openthread commit 473af53.

Signed-off-by: Marius Preda <[email protected]>
Co-authored-by: Gatien Chapon <[email protected]>
Martin-NXP pushed a commit to NXP/matter that referenced this pull request May 26, 2025
@marius-preda @chapongatien
[nxp fromtree][Inet] fix UDP bind with OT stack sha 473af53 and newer (…
581e5f9 
…project-chip#37579)

Testing:
Tested build on NXP K32W1 with Openthread commit 473af53.

Signed-off-by: Marius Preda <[email protected]>
Co-authored-by: Gatien Chapon <[email protected]>
(cherry picked from commit 409ad66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy31415 andy31415 andy31415 approved these changes

@chapongatien chapongatien chapongatien approved these changes

Assignees

No one assigned

Labels

inet review - approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marius-preda @andy31415 @chapongatien