Rename ArraySize() to MATTER_ARRAY_SIZE() #37660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
a93169e to
f933cc4
Compare
|
PR #37660: Size comparison from 38cc24b to 8204eee Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #37660: Size comparison from 38cc24b to b6c7be2 Full report (28 builds for cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, tizen)
|
b6c7be2 to
ad4e7ed
Compare
|
PR #37660: Size comparison from 0551d0a to 1187b7f Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, tizen)
|
|
PR #37660: Size comparison from 40979b4 to 27b8cf9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #37660: Size comparison from 72bd391 to a20d0ac Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37660: Size comparison from 72bd391 to 8b5b7f5 Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Feb 20, 2025
rcasallas-silabs
approved these changes
Feb 20, 2025
|
PR #37660: Size comparison from 72bd391 to 4ee8dea Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Feb 20, 2025
|
PR #37660: Size comparison from 0d6b2fb to 9ee7718 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Contributor
|
Bypassing CLANG-Tidy here - this is a rename update and it just so happens that we touch a file that has new errors (because we do not check all files on all PRS as that is too slow). I cannot see an obvious reason for its complains. |
popovdg
pushed a commit
to popovdg/connectedhomeip
that referenced
this pull request
Feb 25, 2025
* Rename ArraySize() to MATTER_ARRAY_SIZE * Updated usages of ArraySize() to MATTER_ARRAY_SIZE() * Restyled by clang-format * Guard with #ifndef * fix recently introduced usage in chime * fix typo --------- Co-authored-by: Restyled.io <[email protected]>
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
* Rename ArraySize() to MATTER_ARRAY_SIZE * Updated usages of ArraySize() to MATTER_ARRAY_SIZE() * Restyled by clang-format * Guard with #ifndef * fix recently introduced usage in chime * fix typo --------- Co-authored-by: Restyled.io <[email protected]>
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* Rename ArraySize() to MATTER_ARRAY_SIZE * Updated usages of ArraySize() to MATTER_ARRAY_SIZE() * Restyled by clang-format * Guard with #ifndef * fix recently introduced usage in chime * fix typo --------- Co-authored-by: Restyled.io <[email protected]>
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
* Rename ArraySize() to MATTER_ARRAY_SIZE * Updated usages of ArraySize() to MATTER_ARRAY_SIZE() * Restyled by clang-format * Guard with #ifndef * fix recently introduced usage in chime * fix typo --------- Co-authored-by: Restyled.io <[email protected]>
kliffwong
pushed a commit
to kliffwong/connectedhomeip
that referenced
this pull request
May 12, 2025
[QPG] light-switch-app: add battery reporting [QPG] Change CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE to dynamic allocated [QPG] add application_header.c [QPG] Multi-image OTA download additions to Matter SDK [QPG] Diagnostic logs provider implementation [QPG] fix(switch): move battery measurements partially to qpg sdk also fixes a size_t to uint16_t conversion in `DiagnosticLogsProviderDelegateImpl.cpp` Refs: SDP011-2697 [QPG] Move header details to qvCHIP, call reset to apply application update [QPG] Add secure storage for NOC (private) keys The NOC keypair is generated by mbedtls and then pushed to the KeyValueStore. The Qorvo implementation intercepts the `Put` call and encrypts the keypair before committing it to NVM Refs: SDP011-1040 [QPG] apply new kvs api to powercycle_counting Refs: SDP011-1040 [QPG] define constant based on macro [QPG] use esecure api to fetch DAC and sign challenge during commissioning - fallback on using factory data if DAC and key not present in info page Refs: SDP011-1648 [QPG] Adjust to work with new header structure for OTA [QPG] Use mtd libs [QPG] Fixed application start offset [QPG] Enable reset counter to trigger BLE advertisements [QPG] Update in Access Control Cluster to support Extension feature for thermostat application [QPG] Enable Basic Commissioning Feature bit in Administrator Commissioning cluster [QPG] enable test event trigger on thermostat application [QPG] enable ICD management cluster on TRV application (SIT device) [QPG] Enable battery monitoring + Power source cluster on thermostat device [QPG] Fix for BatteryMonitor assert on startup [QPG] use qpg6200 factory data for qpg6200 builds Refs: SDP011-2833 [QPG] Updated ACL feature map for lock [QPG] Fix build error [QPG] Use hexmerge for factorydata [QPG] hexmerge the bootloader [QPG] fix in TotalOperationHours [QPG] Add skip bytes functionality to avoid downloading unnecessary OTA package parts [QPG] Contact sensor example added for QPG platform [QPG] Fix server initialization [QPG] Fix thermostat build [QPG] Fix missing Instance.h header [QPG] Fix cluster revision [QPG] Add hexmerge argument to ignore the execution start address [QPG] Fixing clusters featuremap [QPG] Add occupancy sensor application [QPG] fix switch toggle handler Refs: SDP011-2760 [QPG] add SE and bootloader to multi image ota [QPG] Fix OTA apply update request [QPG] Fix store last OTA provider [QPG] Abort OTA download if we cannot resume after intermediate image apply [QPG] Minor improvements in Thermostat application [QPG] Disable sleep during BLE activity to stabilize BLE Matter commissioning flow [QPG] fix clusters for DoorWindow app [QPG] Fix LED behavior in examples This fixes LED behavior in the following examples: -contact-sensor-app -light-switch-app -lighting-app -lock-app The LED is now blinking after reseting commisioned device. Signed-off-by: Kamil Jawański-Gawor <[email protected]> [QPG] Update endpoint 0 to reflect Root Node, Power Source and OTA Requestor device type [QPG] Set pending image flag for Matter application when the OTA provider... [QPG] Update hexmerge tool path [QPG] Change Switch and MotionSensor cluster Groups to client [QPG] Remove cluster OnOff in MotionSensor [QPG] Unify key format for OTA scripts [QPG] Add qPinCfg support for Matter TRV app [QPG] update minimum app software version to 0.8.3 (SDP013-2249) [QPG] Remove qvIO from Matter apps [QPG] Update factory data credential path [QPG] Fix OnboardingCodesUtil.h location [QPG] Fix assert on interrupts [QPG] Rename ArraySize() to MATTER_ARRAY_SIZE() (project-chip#37660) * Updated usages of ArraySize() to MATTER_ARRAY_SIZE() [QPG] Updated qPin BSP references to correct location in QPG6200 libs package [QPG] Update temperature driver usage with non blocking API [QPG] Install public qorvo-platform-tools [QPG] Sync ZAP configuration for all devices to have common functionality on EP0 for all apps [QPG] Update TRV app to support MSCH feature [QPG] Update TRV ZAP and MATTER file [QPG] Move qPinCfg, LED and button handlers to common directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames ArraySize() to MATTER_ARRAY_SIZE().
ArraySize() is a macro, so it should be in all caps to not be confused with a function. Also, it is a common name. It can cause symbol clashes very easily.
Testing
Pure renaming. Relying on CI to verify build failures.