-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix TestInetEndPoint to pass even when computer is offline #38015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 1 commit into
project-chip:master
from
tcarmelveilleux:fix-inet-test-offline
Mar 17, 2025
Merged
Fix TestInetEndPoint to pass even when computer is offline #38015
mergify
merged 1 commit into
project-chip:master
from
tcarmelveilleux:fix-inet-test-offline
Mar 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up.
cecille
approved these changes
Mar 16, 2025
|
PR #38015: Size comparison from d815fde to e1c84cd Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
approved these changes
Mar 17, 2025
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
…hip#38015) Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up.
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
…hip#38015) Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up.
sayondeep
pushed a commit
to sayondeep/connectedhomeip
that referenced
this pull request
Apr 10, 2025
…hip#38015) Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up.
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Aug 15, 2025
…roject-chip#38015) (project-chip#446) Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Hayk10002
pushed a commit
to Hayk10002/connectedhomeip
that referenced
this pull request
Aug 20, 2025
…hip#38015) Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up.
Hayk10002
pushed a commit
to Hayk10002/connectedhomeip
that referenced
this pull request
Aug 29, 2025
…hip#38015) Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up.
andy31415
added a commit
that referenced
this pull request
Sep 3, 2025
* Fix TestInetEndPoint to pass even when computer is offline (#38015) Description: - TestInetEndPoint was not hermetic, it required at least one network interface connected to a link and up. - There was a comment before to skip tests if the link was not up, but it was not actually skipping the test. This made it fail for me when working offline and trying to run unit tests. Testing done: - Test passes with and without link up. * Add debug logs for test inet limits (#38790) * Add debug log for endpoint full error * Also add assertions that no in use items * Clean up includes * Fix typo in message * Setup ipv6 environment in `REPL Tests - Linux` CI job This change is picked from the PR [#38845](#38845) * Setup ipv6 environment in other places where it's needed * Add sudo to IPV6 setup commands for proper permissions * Revert "Add sudo to IPV6 setup commands for proper permissions" This reverts commit 025cc0c. * Remove `add-apv6` action from `Build on Linux (python_lib)` This doesn't work because of permission issues. * Stop using old ubuntu version (#37870) Co-authored-by: Andrei Litvin <[email protected]> --------- Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing