Fix cycle detection: parts_list_cycles #38127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
PR #38127: Size comparison from 794cc19 to c0c8c11 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38127: Size comparison from 794cc19 to e99ff0f Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Mar 26, 2025
| def parts_list_cycle_detect(visited: set, current_id: int) -> bool: | ||
| if current_id in visited: | ||
| return True | ||
| def parts_list_cycle_detect(visited: set, current_id: int, stack: set) -> bool: |
Contributor
There was a problem hiding this comment.
to find loops you generally only need a single stack, not two separate sets.
The issue here seems to be that we only add to visited, but never remove, so we actually detect more than cycles: we detect re-use across nodes. i.e. we detect non-cycles, but still invalid trees like in your example:
0 ───┐
↓ ↓
1 3
↳ 4 ↵
We should probably just re-name the error or add a comment explaing. The functionality seems on purpose and it does detect an invalid "tree".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
parts_list_cyclesfalsely reports a cycle with Oven device schema. Oven is being added in #38108Schema:
Using
chip-toolto queryparts-listfor each endpoint:Endpoint1:
Endpoint2:
Endpoint3
Endpoint4
Summary -
Output of current
TC_DeviceBasicComposition.py-When the above adjacency list represents a directed graph, there are no back edges and thus no cycle. But the current cycle detection function does not differentiate between back edges and cross edges.
Testing
src/python_testing/TC_DeviceBasicComposition.py