-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add VidVerification payload generation to CHIPCryptoPAL #38284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VidVerification payload generation to CHIPCryptoPAL #38284
Conversation
This PR: - Adds necessary crypto primitives for VID Verification, which will be used by later PRS - Adds the necessary unit tests based on spec test vectors. Testing done: - Added unit test coverage for the new code, matching independent test vectors in spec.
|
PR #38284: Size comparison from c7d1a48 to ffc82da Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
balducci-apple
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'm not sure where else to put these functions but is CHIPCryptoPAL.h the appropriate place ? It does seem like CHIPCryptoPAL.h has some "crypto-adjacent" utilities so maybe it's fine.
Error was:
```
../../src/crypto/tests/TestChipCryptoPAL.cpp:1573:38: note: Access of 'csr' at negative byte offset -2
1573 | csr[length - 2] = (uint8_t) (csr[length - 2] + 1);
| ^~~~~~~~~~~~~~~
WARNING TIDY ../../src/crypto/tests/TestChipCryptoPAL.cpp: 1 warning treated as error
WARNING Tidy ../../src/crypto/tests/TestChipCryptoPAL.cpp ended with code 1
```
Cause was that a EXPECT was used where ASSERT should be used, which leads to
an access in mbedTLS unit test version, that should not have run.
|
PR #38284: Size comparison from c7d1a48 to 837fe2d Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink)
|
|
PR #38284: Size comparison from 61897c7 to 0dd2387 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Changes
Testing