Fix unit test static analyzer warning in TestChipCryptoPAL #38304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was:
```
../../src/crypto/tests/TestChipCryptoPAL.cpp:1573:38: note: Access of 'csr' at negative byte offset -2
1573 | csr[length - 2] = (uint8_t) (csr[length - 2] + 1);
| ^~~~~~~~~~~~~~~
WARNING TIDY ../../src/crypto/tests/TestChipCryptoPAL.cpp: 1 warning treated as error
WARNING Tidy ../../src/crypto/tests/TestChipCryptoPAL.cpp ended with code 1
```
Cause was that a EXPECT was used where ASSERT should be used, which leads to
an access in mbedTLS unit test version, that should not have run.
jmartinez-silabs
approved these changes
Apr 8, 2025
andy31415
approved these changes
Apr 8, 2025
|
PR #38304: Size comparison from 28e8c2d to 6ed65b0 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sayondeep
pushed a commit
to sayondeep/connectedhomeip
that referenced
this pull request
Apr 10, 2025
Error was:
```
../../src/crypto/tests/TestChipCryptoPAL.cpp:1573:38: note: Access of 'csr' at negative byte offset -2
1573 | csr[length - 2] = (uint8_t) (csr[length - 2] + 1);
| ^~~~~~~~~~~~~~~
WARNING TIDY ../../src/crypto/tests/TestChipCryptoPAL.cpp: 1 warning treated as error
WARNING Tidy ../../src/crypto/tests/TestChipCryptoPAL.cpp ended with code 1
```
Cause was that a EXPECT was used where ASSERT should be used, which leads to
an access in mbedTLS unit test version, that should not have run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done
Error was:
Cause was that a EXPECT was used where ASSERT should be used, which leads to an access in mbedTLS unit test version, that should not have run.
Testing
Unit tests still pass, but clang tidy not unhappy on Darwin.