Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CASE: move busy wait time parsing in status report module #38491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

CASE: move busy wait time parsing in status report module #38491

merged 3 commits into from
Apr 25, 2025

Conversation

@shubhamdp
Copy link
Contributor

@shubhamdp shubhamdp commented Apr 19, 2025 •
edited
Loading

Fixes #28487

  • Wait time is being parsed separately in PairingSession. Moved this parsing to StatusReport.
  • Adjusted unit tests

Testing

  • Unit tests pass

  • Manually tested with light-switch-app/esp32 and chip-tool

# Commissioning and access control
./chip-tool pairing ble-wifi 1 (SSID) (PSK) 20202021 3840
./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode":2, "subjects": [ 112233, 1213], "targets": null}]' 1 0x0

# Simultaneously sent below two commands from two different terminals
./chip-tool basicinformation read node-label 1 0
./chip-tool basicinformation read node-label 1 0 --commissioner-nodeid 1213

On chip-tool with node-id 1213, it does 3 retries and failes

[1745222031.995] [20290:127465:chip] [SC] Received busy status report with minimum wait time: 5000 ms
[1745222031.995] [20290:127465:chip] [SC] Received error (protocol code 4) during pairing process: src/protocols/secure_channel/CASESession.cpp:2349: CHIP Error 0x000000DB: The Resource is busy and cannot process the request

On ESP32

I (112763) chip[IN]: Already in the middle of CASE handshake, sending busy status report

@shubhamdp shubhamdp changed the title move busy wait time parsing in status report module CASE: move busy wait time parsing in status report module Apr 19, 2025
@github-actions
Copy link

github-actions bot commented Apr 19, 2025 •
edited
Loading

PR #38491: Size comparison from ff5490a to 16257ad

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ff5490a 16257ad change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098928 1098928 0 0.0
RAM 94850 94850 0 0.0
bl702 lighting-app bl702+eth FLASH 653844 653844 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 831096 831096 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063620 1063620 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894508 894508 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 977296 977296 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818796 818788 -8 -0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827756 827748 -8 -0.0
RAM 125384 125384 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774800 774792 -8 -0.0
RAM 113756 113756 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 759100 759092 -8 -0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542474 542466 -8 -0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576438 576430 -8 -0.0
RAM 205392 205392 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660813 660797 -16 -0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680673 680657 -16 -0.0
RAM 79900 79900 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680673 680657 -16 -0.0
RAM 79900 79900 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637597 637581 -16 -0.0
RAM 72328 72328 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620893 620877 -16 -0.0
RAM 73508 73508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640529 640513 -16 -0.0
RAM 76052 76052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640529 640513 -16 -0.0
RAM 76052 76052 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 640341 640325 -16 -0.0
RAM 76508 76508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 660057 660041 -16 -0.0
RAM 79052 79052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 660057 660041 -16 -0.0
RAM 79052 79052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616737 616737 0 0.0
RAM 70596 70596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636597 636597 0 0.0
RAM 73236 73236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636597 636597 0 0.0
RAM 73236 73236 0 0.0
efr32 lock-app BRD4187C FLASH 942008 942000 -8 -0.0
RAM 132008 132008 0 0.0
BRD4338a FLASH 735864 735904 40 0.0
RAM 206916 206916 0 0.0
window-app BRD4187C FLASH 1033632 1033656 24 0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1800048 1800042 -6 -0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121980 121980 0 0.0
FLASH 1765606 1765638 32 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2749687 2750265 578 0.0
RAM 114264 114264 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6294976 6295460 484 0.0
RAM 532240 532240 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5419840 5420418 578 0.0
RAM 224528 224528 0 0.0
bridge-app debug unknown 5544 5544 0 0.0
FLASH 4719680 4720258 578 0.0
RAM 202880 202880 0 0.0
camera-app debug unknown 8832 8832 0 0.0
FLASH 6793019 6793467 448 0.0
RAM 225264 225264 0 0.0
camera-controller debug unknown 9120 9120 0 0.0
FLASH 13885931 13886411 480 0.0
RAM 646160 646160 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14310035 14310517 482 0.0
RAM 636352 636352 0 0.0
chip-tool-ipv6only arm64 unknown 39696 39696 0 0.0
FLASH 12343856 12344288 432 0.0
RAM 682528 682528 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12411629 12412113 484 0.0
RAM 635712 635712 0 0.0
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4550444 4550990 546 0.0
RAM 190160 190160 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5690005 5690453 448 0.0
RAM 486472 486472 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5620433 5621009 576 0.0
RAM 207144 207144 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4788208 4788786 578 0.0
RAM 194272 194272 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4407894 4408514 620 0.0
RAM 182992 182992 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4540234 4540854 620 0.0
RAM 187464 187464 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3055676 3056124 448 0.0
RAM 147824 147824 0 0.0
thermostat-no-ble arm64 unknown 9560 9560 0 0.0
FLASH 4206536 4207176 640 0.0
RAM 230856 230856 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6037109 6037589 480 0.0
RAM 609888 609888 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12475709 12476109 400 0.0
RAM 754272 754272 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917312 917304 -8 -0.0
RAM 167469 167469 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 909780 909808 28 0.0
RAM 145713 145713 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 853840 853836 -4 -0.0
RAM 141223 141223 0 0.0
nxp contact k32w0+release FLASH 589256 589304 48 0.0
RAM 72836 72836 0 0.0
mcxw71+release FLASH 621208 621264 56 0.0
RAM 63172 63172 0 0.0
light k32w0+release FLASH 615028 615060 32 0.0
RAM 72132 72132 0 0.0
k32w1+release FLASH 705304 705304 0 0.0
RAM 72020 72020 0 0.0
lock mcxw71+release FLASH 770320 770320 0 0.0
RAM 67588 67588 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1662140 1662180 40 0.0
RAM 212352 212352 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1566396 1566412 16 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442692 1442724 32 0.0
RAM 197312 197312 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471468 1471500 32 0.0
RAM 224976 224976 0 0.0
qpg lighting-app qpg6105+debug FLASH 665820 665804 -16 -0.0
RAM 105188 105188 0 0.0
lock-app qpg6105+debug FLASH 624104 624096 -8 -0.0
RAM 99816 99816 0 0.0
stm32 light STM32WB5MM-DK FLASH 463016 463000 -16 -0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 696146 673064 -23082 -3.3
RAM 101860 90712 -11148 -10.9
light-app-ota-compress-lzma-factory-data tl3218x FLASH 777962 777998 36 0.0
RAM 50120 50120 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 768224 768260 36 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 784598 756720 -27878 -3.6
RAM 109308 97540 -11768 -10.8
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 705824 683750 -22074 -3.1
RAM 62620 51588 -11032 -17.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 742006 712200 -29806 -4.0
RAM 85808 73408 -12400 -14.5
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 709710 709746 36 0.0
RAM 37044 37044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603726 603762 36 0.0
RAM 148704 148704 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 819212 791722 -27490 -3.4
RAM 107568 96396 -11172 -10.4
tizen all-clusters-app arm unknown 5164 5164 0 0.0
FLASH 1801660 1801884 224 0.0
RAM 94528 94528 0 0.0
chip-tool-ubsan arm unknown 20272 20272 0 0.0
FLASH 20371078 20372822 1744 0.0
RAM 8876988 8878076 1088 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Apr 24, 2025
View reviewed changes
@shubhamdp shubhamdp mentioned this pull request Apr 25, 2025
Merged
@mergify mergify bot merged commit d67e603 into project-chip:master Apr 25, 2025
72 checks passed
@shubhamdp shubhamdp deleted the busy-status-report branch April 25, 2025 22:59
sayondeep pushed a commit to sayondeep/connectedhomeip that referenced this pull request Apr 26, 2025
@shubhamdp
CASE: move busy wait time parsing in status report module (project-ch…
b3d5772 
…ip#38491)

* move busy wait time parsing in status report module

* remove the unnecessary comment and use std::optional instead of
chip::Optional

* fix clang-tidy
dsavitsky-dsr pushed a commit to popovdg/connectedhomeip that referenced this pull request Apr 29, 2025
@shubhamdp @dsavitsky-dsr
CASE: move busy wait time parsing in status report module (project-ch…
245cc04 
…ip#38491)

* move busy wait time parsing in status report module

* remove the unnecessary comment and use std::optional instead of
chip::Optional

* fix clang-tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tehampson tehampson tehampson approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@andy31415 andy31415 Awaiting requested review from andy31415

@Alami-Amine Alami-Amine Awaiting requested review from Alami-Amine

Assignees

No one assigned

Labels

protocols review - approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CASE: Parse the protocol data for busy status report in StatusReport as well.

3 participants

@shubhamdp @tehampson @bzbarsky-apple