-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Small bugfix and test improvements for VID Verification #38698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 10 commits into
project-chip:master
from
tcarmelveilleux:follow-ups-38469-final
May 2, 2025
Merged
Small bugfix and test improvements for VID Verification #38698
mergify
merged 10 commits into
project-chip:master
from
tcarmelveilleux:follow-ups-38469-final
May 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply follow-ups requested by @bzbarsky-apple in project-chip#38469: - Fix vvvc/vvsc persisten storage key typo - Move the burden of ICAC/VVSC interlock to Fabric table - Document why Fabrics attribute is always reported after VVS/VVSC are touched during fail-safe - Fix documentation of classes to match above. - Minor fix of UpdateNOC handling when VVS/VVSC is involved Testing done: - Added exhaustive cases of fail-safe handling for VVS/VVSC to TestFabricTable.
andy31415
reviewed
Apr 30, 2025
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Show resolved
Hide resolved
andy31415
reviewed
Apr 30, 2025
|
PR #38698: Size comparison from f1bd9ba to 768c482 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38698: Size comparison from f1bd9ba to e751332 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
May 1, 2025
Co-authored-by: C Freeman <[email protected]>
|
PR #38698: Size comparison from f1bd9ba to 43e99fa Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
May 1, 2025
|
PR #38698: Size comparison from f1bd9ba to 26f95a0 Full report (45 builds for cc13x4_26x4, efr32, esp32, linux, nrfconnect, nxp, telink)
|
cecille
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing