Add facilities for parsing concatenated QR codes. #38728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports the format described in section 5.1.6 "Concatenation" in the main Matter specification.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for parsing concatenated QR codes by extending the payload parsing logic and providing additional unit tests for both QR and manual payloads.
- Added new tests in TestSetupPayload.cpp and TestQRCode.cpp to validate various payload scenarios.
- Introduced the FromStringRepresentation API in SetupPayload.{h,cpp} to handle manual and QR code representations.
- Extended QRCodeSetupPayloadParser with new parsing logic to support concatenated payloads.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/setup_payload/tests/TestSetupPayload.cpp | New unit tests for various invalid and valid payload representations for setup payloads. |
| src/setup_payload/tests/TestQRCode.cpp | Added tests to validate QR code extraction and parsing for multiple payloads. |
| src/setup_payload/SetupPayload.h | Introduced the FromStringRepresentation API with detailed documentation. |
| src/setup_payload/SetupPayload.cpp | Implemented FromStringRepresentation handling both manual and QR code payloads. |
| src/setup_payload/QRCodeSetupPayloadParser.h | Added documentation and new helper functions for parsing concatenated payloads. |
| src/setup_payload/QRCodeSetupPayloadParser.cpp | Extended parsing logic to extract and parse individual payload chunks from a QR code. |
Files not reviewed (1)
- src/setup_payload/tests/BUILD.gn: Language not supported
tcarmelveilleux
approved these changes
May 2, 2025
|
PR #38728: Size comparison from 4df81a2 to 2b0bfb3 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38728: Size comparison from 4df81a2 to 7308b90 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Also fix clang-tidy issue with indices.
7308b90 to
7bf4ad8
Compare
|
PR #38728: Size comparison from 928cd29 to 7bf4ad8 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* Just return CHIP_ERROR, not a variant. * Naming and documentation fixes.
ksperling-apple
approved these changes
May 8, 2025
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
May 9, 2025
* Add facilities for parsing concatenated QR codes. This supports the format described in section 5.1.6 "Concatenation" in the main Matter specification. * Address review comments. * Update allow-list for headaers in QRCodeSetupPayloadParser.cpp * Try to fix CI issues by avoiding stringstream. Also fix clang-tidy issue with indices. * Addresss review comments. * Just return CHIP_ERROR, not a variant. * Naming and documentation fixes.
zaid-google
pushed a commit
to zaid-google/connectedhomeip
that referenced
this pull request
May 12, 2025
* Add facilities for parsing concatenated QR codes. This supports the format described in section 5.1.6 "Concatenation" in the main Matter specification. * Address review comments. * Update allow-list for headaers in QRCodeSetupPayloadParser.cpp * Try to fix CI issues by avoiding stringstream. Also fix clang-tidy issue with indices. * Addresss review comments. * Just return CHIP_ERROR, not a variant. * Naming and documentation fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the format described in section 5.1.6 "Concatenation" in the main Matter specification.
Testing
Unit tests included in the PR.