Increase unit test coverage of minimal_mdns/core folder #38906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38906: Size comparison from f4d171a to 47c0027 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
47c0027 to
dbdf5d3
Compare
|
PR #38906: Size comparison from f1830ce to dbdf5d3 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dbdf5d3 to
a38d21f
Compare
|
PR #38906: Size comparison from 2148147 to a38d21f Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
a38d21f to
011ed6d
Compare
|
PR #38906: Size comparison from e665c9f to 011ed6d Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
feasel0
reviewed
May 29, 2025
feasel0
reviewed
May 30, 2025
… is serialized is not valid
andy31415
approved these changes
Jun 10, 2025
zaid-google
pushed a commit
to zaid-google/connectedhomeip
that referenced
this pull request
Jun 10, 2025
…#38906) * Add test to coverage QNameString constructor * Delete spaces * Delete space * Modify QNameString test to use string equal method and check the flow is serialized is not valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complete the expected percentage of coverage of that folder is increasing the coverage of QNameString file. The only Method not actually coverage on the file is the constructor by serialize argument.
increasing the coverage result from 50% to 100%.
That pr is related to the ticket #37242
Testing
To check that is necessary run build_covrage.sh script on master branch and compare with the result that on 37242 branch