Implement the multiple-discriminators BLE connection API on Darwin. #38923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38923: Size comparison from fdacd16 to 4348e97 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This connects to the first device found that matches any of the discriminators and returns that connection.
4348e97 to
438a6ae
Compare
kiel-apple
approved these changes
May 14, 2025
|
PR #38923: Size comparison from 6915d2e to 438a6ae Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ksperling-apple
approved these changes
May 15, 2025
Contributor
ksperling-apple
left a comment
There was a problem hiding this comment.
I guess there's no way to test this yet from MTRBleTests?
Contributor
Author
I think once #38924 merges I should be able to write that test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This connects to the first device found that matches any of the discriminators
and returns that connection.
Draft for now until #38922 merges.
Testing
Manually tested that BLE commissioning still works (and works with concatenated QR codes); there's no way to test this in CI right now.