Add include to MRP analytic delegate to compile #39271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
May 29, 2025
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a compiler error by adding a necessary include directive. The change is clear, concise, and directly solves the reported issue. The PR description and testing validation are appreciated.
Summary of Findings
- Code Correctness: The added
#include <system/SystemClock.h>correctly resolves the 'undeclared identifier System' compiler error, likely due to the usage of types likeSystem::Clock::TimestamporSystem::Clock::Milliseconds64withinReliableMessageAnalyticsDelegate.hor its associated data structures (e.g.,TransmitEvent). This adheres to the C++ best practice of including headers for all types used directly by a file. - Maintainability: The change is minimal and improves the self-containedness of the header file by explicitly declaring its dependencies. The placement of the new include directive is appropriate.
Merge Readiness
The pull request appears to be in good shape and directly addresses a compilation issue. The change is correct and well-justified. Based on this review, the code seems ready for merging. However, as an AI reviewer, I am not authorized to approve pull requests; please ensure it undergoes any further required review processes before merging.
Contributor
|
Fast tracking trivial change. |
tehampson
commented
May 29, 2025
|
|
||
| #include <lib/core/DataModelTypes.h> | ||
| #include <lib/core/NodeId.h> | ||
| #include <system/SystemClock.h> |
Contributor
Author
There was a problem hiding this comment.
Blocking comment. https://github.com/project-chip/connectedhomeip/pull/39253/files fixes the issues as well
|
PR #39271: Size comparison from cac6abc to e7cd28f Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a compiler error that shows up externally in #39201. After addressing a nit comment I forget to text this externally and ended up breaking myself on this effort
Testing
error: use of undeclared identifier 'System'is resolved