src/controller/SetUpCodePairer UTs added. #39214
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1169771 to
714ad6c
Compare
| namespace Controller { | ||
|
|
||
| namespace { | ||
| namespace PayloadUtils { |
Contributor
There was a problem hiding this comment.
This is the anonymous namespace for a reason: it's an implementation detail.
The only reason there is this method is to steer towards QR or Manual code, based on some text input of the "setup code".
These are already individually tested and likely this method should be moved to the setup payload module (src/setup_payload) rather than be made public here.
Also the tests needs below need to validate both QR code path and manual pairing code path, and also failure cases of invalid codes, if we are going to cover this properly.
So suggestions are:
- Move GetPayload API to src/setup_payload, and rename
SetupPayloadFromString. - Move the unit test over there as well.
- Add tests for manual pairing code (11 and 21 digits)
- Add several cases of failure to decode, including empty string.
Contributor
Author
There was a problem hiding this comment.
thanks for your comment @tcarmelveilleux , I put an "early" DRAFT PR to discuss setup payload from Packed Binary Data Structure.
Contributor
Author
There was a problem hiding this comment.
I'll undo these changes on the anonymous namespace
Contributor
There was a problem hiding this comment.
and likely this method should be moved to the setup payload module
Already happened, in #38924.
|
PR #39214: Size comparison from 58d7600 to 714ad6c Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| protected: | ||
| }; | ||
|
|
||
| TEST_F(SetUpCodePairerTest, SuccessfulyPopulatesPayloadFromQRSetUpCode) |
Contributor
There was a problem hiding this comment.
This should all be covered by existing setup_payload unit tests, including the ones added in #38728. See src/setup_payload/tests/TestSetupPayload.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38043
Added unit test file: src/controller/tests/TestSetUpCodePairer.cpp
Testing
Actually it features new file for adding testing coverage into src/controller folder.