Last round of improvements & cleanup to FabricTableImpl for TLS #39518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove no-longer-used kIteratorsMax * Add iteration support via IterateEntries, allowing caller to allocate buffer in stack/heap * Remove last usage of stack allocation of buffer * Pull out common AutoRelease from SessionManager.cpp
|
PR #39518: Size comparison from dbad1e0 to 7600795 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
requested changes
Jun 14, 2025
|
PR #39518: Size comparison from f5be0e4 to 6e7acc7 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
2efb7e7 to
2a540ae
Compare
|
PR #39518: Size comparison from 31c8966 to 2a540ae Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39518: Size comparison from 5eab31e to e360fce Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jun 26, 2025
pidarped
approved these changes
Jun 26, 2025
raveendra-karu
pushed a commit
to raveendra-karu/connectedhomeip
that referenced
this pull request
Jun 26, 2025
…ect-chip#39518) * Last improvements & cleanup to FabricTableImpl for TLS: * Remove no-longer-used kIteratorsMax * Add iteration support via IterateEntries, allowing caller to allocate buffer in stack/heap * Remove last usage of stack allocation of buffer * Pull out common AutoRelease from SessionManager.cpp * Apply review suggestions * Apply review suggestions
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Aug 8, 2025
…ect-chip#39518) * Last improvements & cleanup to FabricTableImpl for TLS: * Remove no-longer-used kIteratorsMax * Add iteration support via IterateEntries, allowing caller to allocate buffer in stack/heap * Remove last usage of stack allocation of buffer * Pull out common AutoRelease from SessionManager.cpp * Apply review suggestions * Apply review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kIteratorsMaxIterateEntries, allowing caller to allocate buffer in stack/heapAutoReleasefromSessionManager.cppRelated issues
Needed for #38895
Testing
CI