-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Last round of improvements & cleanup to FabricTableImpl for TLS #39518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request removes unused code, adds iteration support to FabricTableImpl, removes stack allocation of buffers, and pulls out common AutoRelease functionality. The changes improve code maintainability and efficiency.
* Remove no-longer-used kIteratorsMax * Add iteration support via IterateEntries, allowing caller to allocate buffer in stack/heap * Remove last usage of stack allocation of buffer * Pull out common AutoRelease from SessionManager.cpp
|
PR #39518: Size comparison from dbad1e0 to 7600795 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #39518: Size comparison from f5be0e4 to 6e7acc7 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
2efb7e7 to
2a540ae
Compare
|
PR #39518: Size comparison from 31c8966 to 2a540ae Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39518: Size comparison from 5eab31e to e360fce Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…ect-chip#39518) * Last improvements & cleanup to FabricTableImpl for TLS: * Remove no-longer-used kIteratorsMax * Add iteration support via IterateEntries, allowing caller to allocate buffer in stack/heap * Remove last usage of stack allocation of buffer * Pull out common AutoRelease from SessionManager.cpp * Apply review suggestions * Apply review suggestions
…ect-chip#39518) * Last improvements & cleanup to FabricTableImpl for TLS: * Remove no-longer-used kIteratorsMax * Add iteration support via IterateEntries, allowing caller to allocate buffer in stack/heap * Remove last usage of stack allocation of buffer * Pull out common AutoRelease from SessionManager.cpp * Apply review suggestions * Apply review suggestions
Summary
kIteratorsMaxIterateEntries, allowing caller to allocate buffer in stack/heapAutoReleasefromSessionManager.cppRelated issues
Needed for #38895
Testing
CI