Improve template deduction rules for Span and List. #39691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows writing List(someArray) instead of having to specify the type of the thing stored in the array, and same for Span.
Contributor
There was a problem hiding this comment.
Code Review
The pull request improves template deduction rules for Span and List, allowing for more concise code when constructing these objects. The changes include adding template deduction guides and corresponding unit tests. The feedback suggests adding comments to explain the purpose of the template deduction guides and the added dependency in the build file to improve code readability and maintainability.
|
PR #39691: Size comparison from 31c8966 to 6ad781b Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jun 24, 2025
arkq
approved these changes
Jun 25, 2025
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Aug 8, 2025
* Improve template deduction rules for Span and List. This allows writing List(someArray) instead of having to specify the type of the thing stored in the array, and same for Span. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows writing List(someArray) instead of having to specify the type of the thing stored in the array, and same for Span.
Testing
Unit tests added.