Increase unit test code coverage of ble/ by 1.6%
#39618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new unit tests for the BtpEngine::HandleCharacteristicSend method in the ble module to increase the overall test coverage for BLE packet handling.
- Added tests for single packet send with acknowledgment
- Added tests for multi-packet sends with both correct and incorrect acknowledgment sequences
- Added tests to validate rejection of new sends during an in-progress transmission and to check error handling when packet buffers have insufficient headroom
Comments suppressed due to low confidence (1)
src/ble/tests/TestBtpEngine.cpp:274
- [nitpick] Consider using System::PacketBufferHandle::New consistently for creating packet buffers across all tests to improve clarity and maintain conformity in naming.
auto packet0 = PacketBufferHandle::New(chip::System::PacketBuffer::kMaxSize, 0);
Contributor
There was a problem hiding this comment.
Code Review
This PR increases ble unit test coverage by adding comprehensive unit tests for the BtpEngine::HandleCharacteristicSend method. The new tests cover various scenarios for BLE packet transmission, including sending single and multi-packet payloads, testing acknowledgment sequences, ensuring the engine rejects new sends until the previous payload is fully acknowledged, and handling cases where the packet buffer lacks sufficient headroom. The added tests are well-structured and contribute positively to code quality. The review includes suggestions to enhance clarity in test naming and comments.
|
PR #39618: Size comparison from 0657d7d to daa2e08 Full report (3 builds for cc32xx, stm32)
|
|
PR #39618: Size comparison from 0657d7d to 6c8b592 Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39618: Size comparison from 0657d7d to 1c2d19f Full report (3 builds for cc32xx, stm32)
|
1c2d19f to
de4d19d
Compare
|
PR #39618: Size comparison from 0657d7d to de4d19d Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
de4d19d to
4d03fb4
Compare
|
PR #39618: Size comparison from a8ab4d5 to 4d03fb4 Full report (3 builds for cc32xx, stm32)
|
dd0e897 to
8cd5ed2
Compare
|
PR #39618: Size comparison from 0bac726 to 8cd5ed2 Full report (3 builds for cc32xx, stm32)
|
d824df8 to
be66643
Compare
|
PR #39618: Size comparison from 0bac726 to be66643 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39618: Size comparison from 3c9946c to ee8c42a Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ee8c42a to
0fc0434
Compare
|
PR #39618: Size comparison from 852d123 to 0fc0434 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Added test for HandleCharacteristicSend with empthy packet with ACK
-Added test to verify with one packet and acknowledgment requestes
0fc0434 to
cf1571e
Compare
|
PR #39618: Size comparison from 2d454ec to cf1571e Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Aug 8, 2025
* Add unit tests for BrpEngine - Added test for HandleCharacteristicSend with empthy packet with ACK * Add unit test for HandleCharacteristicSend -Added test to verify with one packet and acknowledgment requestes * Added test for insufficient headroom * Changeed structure of tests and add tests * Added the new test for send two packets with correct usage of ack * Added HandleCharacteristicSendRejectsNewSendUntilPreviousAcked test * Corrections in HandleCharacteristicSendInsufficientHeadroom test * Added comments * Update TestBtpEngine.cpp * Update TestBtpEngine.cpp * Update TestBtpEngine.cpp * Defined named constants for header size and expected packet lengths * Fix for clang-format * Corrected variables types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR increases
bleunit test coverage from 65.6% to 67.2% by adding comprehensive unit tests for theBtpEngine::HandleCharacteristicSendmethod inTestBtpEngine. The new tests cover various scenarios for BLE packet transmission, including:Related issues
Main issue #37232
Testing
This PR only adds new unit tests. No changes made to production code.