Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JoshuaC215
Copy link
Collaborator

@JoshuaC215 JoshuaC215 commented May 25, 2017

Benchmarks:
image

This commit has full compatibility, with updates made in place and old
methods maintained as well. This provides for better code review to see
changes from new to old, and provides a commit where old and new versions
can be tested side by side and verified that they have identical output
for all unit tests (besides a few cases of ordering changes in marshalling).
@ryanleary
Copy link
Contributor

These improvements are tremendous. Two thoughts:

  1. We should keep this as a topic branch for now and tag some RC releases and test in production to make sure there aren't any real-world use cases broken that aren't covered in tests
  2. We will either need to roll the major version number (due to breaking API changes) or we can do a minor version change and maintain but deprecate the simplejson-based API.

@JoshuaC215
Copy link
Collaborator Author

Thanks @ryanleary, will get it over to an RC branch. From earlier discussion with @chilland I think we want to do a major version rev to v3 once this is finalized (assuming you're good with that) - it ends up being a lot of duplicated code to try to maintain both.

@JoshuaC215 JoshuaC215 changed the base branch from master to v3-rc1 May 25, 2017 23:31
@ryanleary
Copy link
Contributor

Fine by me. Let's merge it to a v3 branch and tag as rc1 then get it integrated for testing.

@JoshuaC215
Copy link
Collaborator Author

Updated to remove required JSON validation, which significantly slowed down all the transforms.

@JoshuaC215 JoshuaC215 merged commit fbcdc7f into qntfy:v3-rc1 May 26, 2017
@JoshuaC215 JoshuaC215 deleted the use-jsonparser branch June 2, 2017 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants