Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Drop support for python 3.9 #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

Drop support for python 3.9 #560

merged 1 commit into from
Jan 4, 2024

Conversation

@zmeir
Copy link
Contributor

@zmeir zmeir commented Jan 3, 2024 •
edited by qodo-merge-pro bot
Loading

Type

Enhancement

Description

This PR updates the required Python version for the project. The change is made in the pyproject.toml file:

  • The requires-python version has been updated from ">=3.9" to ">=3.10". This is due to the use of structural pattern matching in bitbucket_server_provider.py, which was introduced in Python 3.10.

PR changes walkthrough

Relevant files                                                                                                                                 
Configuration changes
1 files
pyproject.toml                                                                                           
    pyproject.toml

    The requires-python version has been updated from ">=3.9"
    to ">=3.10".

 +1/-1

User description

The bitbucket_server_provider.py uses structural pattern matching that was introduced in python 3.10, and so trying to run any command with python 3.9 will fail (because we import all the providers right at the top of pr_agent.git_providers)

@zmeir
Drop support for python 3.9
58f93e0 
The `bitbucket_server_provider.py` uses structural pattern matching that was introduced in python 3.10, and so trying to run any command with python 3.9 will fail (because we import all the providers right at the top of `pr_agent.git_providers`)
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Jan 3, 2024

PR Description updated to latest commit (58f93e0)

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Jan 3, 2024

PR Analysis

  • 🎯 Main theme: Dropping support for Python 3.9
  • 📝 PR summary: This PR updates the required Python version for the project from ">=3.9" to ">=3.10". This is due to the use of structural pattern matching in bitbucket_server_provider.py, which was introduced in Python 3.10.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 1, because the PR contains a single line change in the configuration file.
  • 🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is straightforward and the change is well explained in the PR description. However, it would be beneficial to add a note in the README file about the updated Python version requirement.

🤖 Code feedback:
relevant filepyproject.toml
suggestion      

Consider adding a comment in the code explaining why Python 3.10 is required, for future reference. [medium]

relevant linerequires-python = ">=3.10"

✨ Usage tips:

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /add_docs 💎: Generate docstring for new components introduced in the PR.
  • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
  • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

@mrT23
Copy link
Contributor

mrT23 commented Jan 4, 2024

👍

@mrT23 mrT23 merged commit c07ea5e into qodo-ai:main Jan 4, 2024
@zmeir zmeir deleted the zmeir/fix/drop_python3.9 branch January 4, 2024 07:24
yochail pushed a commit to yochail/pr-agent that referenced this pull request Feb 11, 2024
@mrT23
Merge pull request qodo-ai#560 from zmeir/zmeir/fix/drop_python3.9
b46e01a 
Drop support for python 3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrT23 mrT23 mrT23 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zmeir @mrT23