simplify object_usage helper function, fix error #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
commented
Apr 16, 2022
R/object_usage_linter.R
Outdated
| setmethod_assignment_functions <- | ||
| xml2::xml_find_all(xml, "expr[expr[SYMBOL_FUNCTION_CALL/text()='setMethod']]/expr[3]") | ||
| direct_assignment_functions <- | ||
| xml2::xml_find_all(xml, "//*[((self::expr and LEFT_ASSIGN) or (self::expr_or_assign_or_help and EQ_ASSIGN)) and expr[2][FUNCTION]]/expr[2]") |
There was a problem hiding this comment.
we could also consider combining the two xpaths here to avoid calling xml_find_all() twice, but for now I left it for readability.
AshesITR
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1081