Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added lint-changed-files CI workflow #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 2, 2020
Merged

added lint-changed-files CI workflow #652

merged 10 commits into from
Dec 2, 2020

Conversation

@dragosmg
Copy link
Collaborator

@dragosmg dragosmg commented Dec 1, 2020 •
edited
Loading

closes #641

still to-do:

  • name for the secondary lintr config file - it will be named .lintr_new
  • content of the secondary config file - content added as
linters: with_defaults(
    line_length_linter = line_length_linter(120),
    T_and_F_symbol_linter = T_and_F_symbol_linter
  )
exclusions: list(
  "tests/testthat/dummy_packages",
  "tests/testthat/knitr_formats",
  "tests/testthat/knitr_malformed",
  "inst",
  "vignettes"
 )
  • check the double exclusion of files gives the intended result
  • change the lint workflow to exclude changed files (linted here)? - no, the main lint workflow will be left as is
  • add news note?

AshesITR
AshesITR approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

The build failure was a sporadic HTTP 502 so no real error.

@dragosmg dragosmg marked this pull request as ready for review December 2, 2020 18:31
@AshesITR AshesITR merged commit 430d28a into r-lib:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Find changed files and apply a different .lintr config

2 participants

@dragosmg @AshesITR