Add reformat argument to use_rstudio()
#1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And set to `FALSE` in `create_from_github()`. Fixes #1679
jennybc
approved these changes
Sep 21, 2022
Member
jennybc
left a comment
There was a problem hiding this comment.
Coming in cold, it took me a moment to really absorb what the issue here is. I wondered if this was about reformatting the .Rproj file itself. Or if we were trying to merge local and remote .Rproj files. (Neither of which is true.)
So I made a few suggestions that helped me understand what's actually going on.
| rstudio <- rstudio && !is_rstudio_project(proj_get()) | ||
| if (rstudio) { | ||
| use_rstudio() | ||
| use_rstudio(reformat = FALSE) |
Member
There was a problem hiding this comment.
Suggested change
| use_rstudio(reformat = FALSE) | |
| use_rstudio(reformat = !fork) |
There is part of me that thinks we should only set reformat = FALSE in a fork, but I can also ignore that part of me.
Member
Author
There was a problem hiding this comment.
Regardless of whether you're forking or not, I feel like you should leave the code alone.
Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And set to
FALSEincreate_from_github(). Fixes #1679