Implement use_standalone()
#1748
Conversation
|
Requires r-lib/rlang#1548 |
#Conflicts: # NEWS.md
jennybc
left a comment
There was a problem hiding this comment.
I realize this is a draft and is unfinished, but I made one pass on my way through the usethis notifications.
|
Note to self: unskip "use_tidy_dependencies() isn't overly informative" test when this concludes. |
Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
DavisVaughan
left a comment
There was a problem hiding this comment.
I used it here and it worked well! tidyverse/dplyr#6722
jennybc
left a comment
There was a problem hiding this comment.
I think the main thing to settle is whether to make this work for GHE. I think we should do it, since we've met that standard everywhere else.
jennybc
left a comment
There was a problem hiding this comment.
With the caveat that I didn't manually test on GHE, yes, I think this is good to go (after you take my suggestion to pass host to standalone_choose()).
One last suggestion: in create_from_github(), perhaps we should clarify the docs a bit, now they are being inherited elsewhere.
Such as:
For create_from_github(), the REPO part will be the name of the new local folder, which is also a project and Git repo.
Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
|
@jennybc the docs were a bit tangled, but I think I've made an improvement. Anyway, I'm going to merge this PR so it's off my plate, and you should feel free to tweak the docs as you see fit. |
Fixes #1654