Support all cgi.gem versions #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since https://bugs.ruby-lang.org/issues/21258, Ruby 3.5+ no longer ships cgi.gem. So we've removed the cgi.gem dependency from erb.gem #59.
This PR adds the original implementation of
CGI.escapeURIComponentbefore #23 as a fallback in case cgi.gem v0.3.2 or older is used. The method was first added in cgi.gem v0.3.3.This PR also bumps
required_ruby_versionto Ruby 3.2, which ships cgi.gem v0.3.6, to minimize the possibility of the fallback implementation used for CRuby. Note that Ruby 3.1 reached EOL on March 31st, 2025, so we're not obligated to support Ruby 3.1 or older anyway. The CI doesn't test those versions either.I also added a comment to clarify why
require 'cgi/escape'is enough forERB::Util. erb.gem shouldn't need torequire 'cgi/util', which is warned in Ruby 3.5, even for TruffleRuby.