[2.2.x] Add Project Member Issues #3048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so groups and the like are still visible rancher/rancher#20825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes two issues, the first being when adding group members to a project they would not show up on the index page. This change filtered out all the PRTBs on the members page that didn't contain the users id to filter the service account the would surface from enabling project monitoring. Instead we'll filter by the service account param. The second was when adding a member from the form-members component a type error would occur and cause the member to not be added. A closure action was missed when the deprecations were dealt with.
Types of changes
Bugfix
Linked Issues
rancher/rancher#20826
rancher/rancher#20825
Further comments
N/A